Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe plugin restart policies #286

Merged
merged 3 commits into from
Sep 25, 2023
Merged

Describe plugin restart policies #286

merged 3 commits into from
Sep 25, 2023

Conversation

josefkarasek
Copy link

Description

Changes proposed in this pull request:

  • Describe plugin restart policies

Testing

Related issue(s)

kubeshop/botkube#878

@josefkarasek josefkarasek added the enhancement New feature or request label Sep 25, 2023
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 25, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 798752b
Status: ✅  Deploy successful!
Preview URL: https://05dfcc2d.botkube-docs-58l.pages.dev
Branch Preview URL: https://restart-plugins.botkube-docs-58l.pages.dev

View logs

Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor comment


This section of the configuration allows you to configure the restart policy for the Botkube executor plugins. The restart policy is used when the executor plugin fails to start. The default restart policy is `DeactivatePlugin`, which means that the plugin is deactivated after a given number of restarts. The restart policy can be configured with the following properties:

- `type` - restart policy type. Allowed values: `RestartAgent`, `DeactivatePlugin`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we describe the possible values? One sentence per the value would be enough.
Please apply that to each document.
Thanks!

@josefkarasek josefkarasek merged commit 63ba233 into main Sep 25, 2023
3 checks passed
@josefkarasek josefkarasek deleted the restart-plugins branch September 25, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants