-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change capitalisation of "pod" and "etcd" throughout #513
Conversation
Signed-off-by: Craig Box <[email protected]>
PR Analysis
PR Feedback
How to use
|
Summary:
|
Summary:
|
Summary:
|
PR Type:
Refactoring
PR Description:
This PR standardizes the capitalization of 'pod' and 'etcd' across various files in the codebase. Previously, these terms were inconsistently capitalized, sometimes appearing as 'POD' or 'ETCD'. The changes mainly involve updating descriptions, remediations, and long descriptions in various control files, as well as some instances in the README and framework files. The PR aims to improve readability and consistency in the codebase.
PR Main Files Walkthrough:
files:
controls/C-0075-imagepullpolicyonlatesttag.json
: Updated the capitalization of 'pod' in the description, remediation, and long_description fields.frameworks/cis-eks-t1.2.0.json
: Corrected the capitalization of 'etcd' in the manual_test field.controls/C-0073-nakedpods.json
: Changed the capitalization of 'pod' in the name, description, remediation, and long_description fields.controls/C-0009-resourcelimits.json
: Updated the capitalization of 'pod' in the description, remediation, and long_description fields.README.md
: Corrected the capitalization of 'pod' in the example control and its description.controls/C-0038-hostpidipcprivileges.json
: Updated the capitalization of 'pod' in the description and long_description fields.controls/C-0056-configuredlivenessprobe.json
: Corrected the capitalization of 'pod' in the description and long_description fields.controls/C-0061-podsindefaultnamespace.json
: Updated the capitalization of 'pod' in the description, remediation, and long_description fields.controls/C-0034-automaticmappingofserviceaccount.json
: Corrected the capitalization of 'pod' in the description and remediation fields.controls/C-0048-hostpathmount.json
: Updated the capitalization of 'pod' in the description field.User Description:
POD and ETCD aren't acronyms, so they should never be
SHOUTEDwritten in all caps.This PR is a very considered search and replace across the library.
KUBELET_SYSTEM_PODS_ARGS
should remain in caps, for example.This is my third attempt. Please merge this one quickly!
Signed-off-by: Craig Box [email protected]