Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix control C-0211 #501

Merged
merged 2 commits into from
Sep 4, 2023
Merged

Fix control C-0211 #501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f794ed
fix typo
YiscahLevySilas1 Sep 3, 2023
3b2762d
add test case
YiscahLevySilas1 Sep 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion controls/C-0211-applysecuritycontexttoyourpodsandcontainers.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"set-procmount-default",
"set-fsgroup-value",
"set-fsgroupchangepolicy-value",
"set-systctls-params",
"set-sysctls-params",
"set-supplementalgroups-values"
],
"baseScore": 8,
Expand Down
30 changes: 15 additions & 15 deletions rules/set-systctls-params/raw.rego → rules/set-sysctls-params/raw.rego
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,18 @@ package armo_builtins

### POD ###

# Fails if securityContext.systctls is not set
# Fails if securityContext.sysctls is not set
deny[msga] {
# verify the object kind
pod := input[_]
pod.kind = "Pod"

# check securityContext has systctls set
not pod.spec.securityContext.systctls
# check securityContext has sysctls set
not pod.spec.securityContext.sysctls

path := "spec.securityContext.systctls"
path := "spec.securityContext.sysctls"
msga := {
"alertMessage": sprintf("Pod: %v does not set 'securityContext.systctls'", [pod.metadata.name]),
"alertMessage": sprintf("Pod: %v does not set 'securityContext.sysctls'", [pod.metadata.name]),
"packagename": "armo_builtins",
"alertScore": 7,
"failedPaths": [],
Expand All @@ -26,19 +26,19 @@ deny[msga] {

### WORKLOAD ###

# Fails if securityContext.systctls is not set
# Fails if securityContext.sysctls is not set
deny[msga] {
# verify the object kind
wl := input[_]
manifest_kind := {"Deployment","ReplicaSet","DaemonSet","StatefulSet","Job"}
manifest_kind[wl.kind]

# check securityContext has systctls set
not wl.spec.template.spec.securityContext.systctls
# check securityContext has sysctls set
not wl.spec.template.spec.securityContext.sysctls

path := "spec.template.spec.securityContext.systctls"
path := "spec.template.spec.securityContext.sysctls"
msga := {
"alertMessage": sprintf("Workload: %v does not set 'securityContext.systctls'", [wl.metadata.name]),
"alertMessage": sprintf("Workload: %v does not set 'securityContext.sysctls'", [wl.metadata.name]),
"packagename": "armo_builtins",
"alertScore": 7,
"failedPaths": [],
Expand All @@ -51,18 +51,18 @@ deny[msga] {

### CRONJOB ###

# Fails if securityContext.systctls is not set
# Fails if securityContext.sysctls is not set
deny[msga] {
# verify the object kind
cj := input[_]
cj.kind == "CronJob"

# check securityContext has systctls set
not cj.spec.jobTemplate.spec.template.spec.securityContext.systctls
# check securityContext has sysctls set
not cj.spec.jobTemplate.spec.template.spec.securityContext.sysctls

path := "spec.jobTemplate.spec.template.spec.securityContext.systctls"
path := "spec.jobTemplate.spec.template.spec.securityContext.sysctls"
msga := {
"alertMessage": sprintf("CronJob: %v does not set 'securityContext.systctls'", [cj.metadata.name]),
"alertMessage": sprintf("CronJob: %v does not set 'securityContext.sysctls'", [cj.metadata.name]),
"packagename": "armo_builtins",
"alertScore": 7,
"failedPaths": [],
Expand Down
6 changes: 3 additions & 3 deletions rules/set-systctls-params/rule.metadata.json → rules/set-sysctls-params/rule.metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "set-systctls-params",
"name": "set-sysctls-params",
"attributes": {
"armoBuiltin": true
},
Expand Down Expand Up @@ -45,7 +45,7 @@
],
"ruleDependencies": [
],
"description": "Fails if securityContext.systctls is not set.",
"remediation": "Set securityContext.systctls params",
"description": "Fails if securityContext.sysctls is not set.",
"remediation": "Set securityContext.sysctls params",
"ruleQuery": "armo_builtins"
}
4 changes: 2 additions & 2 deletions ...ystctls-params/test/cronjob/expected.json → ...sysctls-params/test/cronjob/expected.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
[
{
"alertMessage": "CronJob: hello does not set 'securityContext.systctls'",
"alertMessage": "CronJob: hello does not set 'securityContext.sysctls'",
"packagename": "armo_builtins",
"alertScore": 7,
"failedPaths": [],
"fixPaths": [{"path": "spec.jobTemplate.spec.template.spec.securityContext.systctls", "name": "net.ipv4.tcp_syncookie", "value": "1"}],
"fixPaths": [{"path": "spec.jobTemplate.spec.template.spec.securityContext.sysctls", "name": "net.ipv4.tcp_syncookie", "value": "1"}],
"ruleStatus": "",
"alertObject": {
"k8sApiObjects": [
Expand Down
0 ...s-params/test/cronjob/input/cronjob1.yaml → ...s-params/test/cronjob/input/cronjob1.yaml
View file
Open in desktop
File renamed without changes.
1 change: 1 addition & 0 deletions rules/set-sysctls-params/test/pod-pass/expected.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[]
15 changes: 15 additions & 0 deletions rules/set-sysctls-params/test/pod-pass/input/pod1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
apiVersion: v1
Dismissed Show dismissed Hide dismissed
kind: Pod
metadata:
name: sysctl-example
Dismissed Show dismissed Hide dismissed
spec:
securityContext:
Dismissed Show dismissed Hide dismissed
sysctls:
Dismissed Show dismissed Hide dismissed
- name: net.core.somaxconn
value: "1024"
- name: kernel.shm_rmid_forced
value: "0"
containers:
- name: sysctl-test-container
Dismissed Show dismissed Hide dismissed
Dismissed Show dismissed Hide dismissed
Dismissed Show dismissed Hide dismissed
Dismissed Show dismissed Hide dismissed
Dismissed Show dismissed Hide dismissed
Dismissed Show dismissed Hide dismissed
image: busybox
command: [ "sleep", "1000000" ]
4 changes: 2 additions & 2 deletions ...et-systctls-params/test/pod/expected.json → ...set-sysctls-params/test/pod/expected.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
[
{
"alertMessage": "Pod: nginx does not set 'securityContext.systctls'",
"alertMessage": "Pod: nginx does not set 'securityContext.sysctls'",
"packagename": "armo_builtins",
"alertScore": 7,
"failedPaths": [],
"fixPaths": [{"path": "spec.securityContext.systctls", "name": "net.ipv4.tcp_syncookie", "value": "1"}],
"fixPaths": [{"path": "spec.securityContext.sysctls", "name": "net.ipv4.tcp_syncookie", "value": "1"}],
"ruleStatus": "",
"alertObject": {
"k8sApiObjects": [
Expand Down
0 ...-systctls-params/test/pod/input/pod1.yaml → ...t-sysctls-params/test/pod/input/pod1.yaml
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions ...stctls-params/test/workload/expected.json → ...ysctls-params/test/workload/expected.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
[
{
"alertMessage": "Workload: my-deployment does not set 'securityContext.systctls'",
"alertMessage": "Workload: my-deployment does not set 'securityContext.sysctls'",
"packagename": "armo_builtins",
"alertScore": 7,
"failedPaths": [],
"fixPaths": [{"path": "spec.template.spec.securityContext.systctls", "name": "net.ipv4.tcp_syncookie", "value": "1"}],
"fixPaths": [{"path": "spec.template.spec.securityContext.sysctls", "name": "net.ipv4.tcp_syncookie", "value": "1"}],
"ruleStatus": "",
"alertObject": {
"k8sApiObjects": [
Expand Down
0 ...rams/test/workload/input/deployment1.yaml → ...rams/test/workload/input/deployment1.yaml
View file
Open in desktop
File renamed without changes.
Loading