-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change capitalisation of "pod" and "etcd" throughout #336
Conversation
Signed-off-by: Craig Box <[email protected]>
Signed-off-by: Craig Box <[email protected]>
Is it |
@YiscahLevySilas1 - do we have any dependencies with other files / libraries which might be affected from this change ? (name convention or any other issue?) |
That is a contentious question. SIG Docs guidance is roughly 'When you're talking about a pod, you should say pod; when you're talking about a pod's API object, you should say (We don't have the markdown differentiation.) |
Signed-off-by: Craig Box <[email protected]>
Signed-off-by: Craig Box <[email protected]>
@craigbox Sorry for the delay here! |
Does that not restrict things such that only maintainers can contribute, as only they can create branches in the repo? |
@craigbox - We just inserted this option in the past week. The issue is that we cannot perform any test over opened forks because of the secrets which are related to the organization. |
@yuleib any update on this issue lately? |
@rotemamsa - same as #323 |
replacing with #513. |
POD and ETCD aren't acronyms, so they should never be
SHOUTEDwritten in all caps.This PR is a very considered search and replace across the library.
KUBELET_SYSTEM_PODS_ARGS
should remain in caps, for example.