Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubescape.exe to the release assets #1169

Merged
merged 2 commits into from
May 1, 2023
Merged

Add kubescape.exe to the release assets #1169

merged 2 commits into from
May 1, 2023

Conversation

HollowMan6
Copy link
Contributor

Overview

Resolve #1168 and mark kubescape-windows-latest as deprecated.

@matthyx
Copy link
Contributor

matthyx commented Apr 17, 2023

LGTM, please check with @dwertent on the rollout schedule, as we don't want users to have issues when updating

@HollowMan6
Copy link
Contributor Author

@dwertent I hope this can get merged before the next release, so that I can start working on migrating packages to chocolatey community chocolatey-community/chocolatey-packages#2190

@HollowMan6
Copy link
Contributor Author

HollowMan6 commented Apr 20, 2023

For this PR, kubescape-windows-latest is just marked as deprecated, it can depends on you to decide when this will get deprecated later, I will open a separate PR to allow you deprecate kubescape-windows-latest after this got merged.

@dwertent
Copy link
Contributor

dwertent commented May 1, 2023

@HollowMan6 can you please resolve the conflict?

@HollowMan6
Copy link
Contributor Author

Done! @dwertent

@HollowMan6 can you please resolve the conflict?

@HollowMan6
Copy link
Contributor Author

HollowMan6 commented May 1, 2023

@dwertent Maybe it's a good idea to get this merged before the v2.3.0 release, so that I can start working on migrating the package repo to Chocolatey Community: #1168

@dwertent
Copy link
Contributor

dwertent commented May 1, 2023

I'm sorry, I did not notice that I didn't merge :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add kubescape.exe to the release assets to replace kubescape-windows-latest
3 participants