kubeadm-init: update notes related to the configuration #9638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
sig/cluster-lifecycle
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 2a1095f https://deploy-preview-9638--kubernetes-io-master-staging.netlify.com |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
luxas
approved these changes
Jul 25, 2018
| @@ -102,6 +102,8 @@ configuration file options. This file is passed in the `--config` option. | |||
|
|
|||
| In Kubernetes 1.11 and later, the default configuration can be printed out using the | |||
| [kubeadm config print-default](/docs/reference/setup-tools/kubeadm/kubeadm-config/) command. | |||
| It is **recommended** that you migrate your old `v1alpha1` configuration to `v1alpha2` using | |||
| the [kubeadm config migrate](/docs/reference/setup-tools/kubeadm/kubeadm-config/) command. | |||
There was a problem hiding this comment.
You can add that v1.12 won't be able to read v1alpha1 anymore...
k8s-ci-robot
removed
the
lgtm
- mention `kubeadm config migrate`. - don't inline control plane flag info, but rather link to the new dedicated page. - mention that kuberenetesVersion controls the version of the images.
|
/approve |
|
@kubernetes/sig-docs-maintainers |
|
/approve (only sig-docs approvers can approve) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dixudx, mistyhacks, timothysc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a small PR that applies a temporary fix based on recent 1.11 user feedback.
the
kubeadm initref page seems to be the go-to page for users. we should really move all authored content out of the reference pages in to the "creating a cluster" related pages. i have a plan on starting this next week.mention
kubeadm config migrate.don't inline control plane flag info, but rather link
to the new dedicated page.
mention that kubernetesVersion controls the version of the
images.
Fixes kubernetes/kubeadm#1018
/assign @Bradamant3
/cc @kubernetes/sig-cluster-lifecycle-pr-reviews