Remove InitialResources from admission controllers #8293

tengqm · 2018-05-03T07:23:31Z

The feature (was experimental) is dropped in 1.11.

xref: kubernetes/kubernetes#58784

k8sio-netlify-preview-bot · 2018-05-03T07:27:00Z

Deploy preview for kubernetes-io-vnext-staging processing.

Built with commit 3248120

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5b0736dbb13fb13d677faa30

zacharysarah · 2018-05-11T18:48:07Z

/cc @MistyHacks

mdlinville · 2018-05-16T22:45:52Z

The underlying structure of the docs repository has changed due to the recent
Hugo migration. Specifically, all the files previously under docs/ are now in
content/en/docs/. I have rebased your PR without changing any of your work, so
that your changes are modifying the affected files in the new location, so this
PR is now reviewable again.

If you were using Github's web UI rather than a local Git client, you can stop
reading and continue working in this PR.

If you use the Git command-line client, you will need to make sure your local
branch is up to date with your fork. If you have local commits that have not
been pushed to your fork, it may be complicated to get them back. Do git log
and note their commit hashes for later.

Assuming your your fork's remote is called origin, hard-reset your local
branch to be the same as your fork's branch:

git fetch origin; git reset --hard origin/rm-initialresources

If you didn't have local commits, you're now ready to keep working on this PR
locally. You can stop reading now.

If you did have local commits, cherry-pick them from oldest to newest. For
each commit that needs to be cherry-picked:

git cherry-pick <HASH>

You will need to resolve conflicts in these cherry-picked commits, which
involves moving your modified files into the correct new location. All the
content in docs/ moved to content/en/docs/, so you can move your local files
accordingly:

Do git add for each of the moved files
Do git mergetool and accept the
deleted rather than modified file
Continue the cherry-pick by doing git cherry-pick --continue

When you've cherry-picked all local commits back onto the local branch, push the
branch (with new commits) to your fork. You should not need to force the push.

mdlinville

A few Hugo-migration-related things need to be addressed. Thanks!

mdlinville · 2018-05-16T22:47:10Z

content/en/docs/admin/admission-controllers.md

@@ -9,7 +9,8 @@ reviewers:
 title: Using Admission Controllers
 ---

-{{< toc >}}
+* TOC
+{:toc}


This might need to be changed to match the old line 12.
/assign @chenopis

mdlinville · 2018-05-16T22:47:38Z

content/en/docs/admin/admission-controllers.md

 **Note**: Depending on the way your Kubernetes cluster is deployed and how the
 API server is started, you may need to apply the settings in different ways.
 For example, you may have to modify the systemd unit file if the API server is
 deployed as a systemd service, you may modify the manifest file for the API
 server if Kubernetes is deployed in a self-hosted way.
-{{< /note >}}


These need to be reverted to the red lines 63 and 69, to use the Hugo shortcodes.

mdlinville · 2018-05-16T22:48:07Z

content/en/docs/admin/admission-controllers.md

 **Note:** PodNodeSelector allows forcing pods to run on specifically labeled nodes. Also see the PodTolerationRestriction 
 admission plugin, which allows preventing pods from running on specifically tainted nodes.
-{{< /note >}}
+{: .note}


Also revert to use Hugo shortcodes here and any other admonitions changed in this PR.

mdlinville · 2018-05-16T22:48:49Z

content/en/docs/admin/admission-controllers.md

 We strongly recommend using this admission controller if you intend to make use of Kubernetes `ServiceAccount` objects.

 ### Storage Object in Use Protection (beta)
-{{< feature-state for_k8s_version="v1.10" state="beta" >}}
+{% assign for_k8s_version="v1.10" %}{% include feature-state-beta.md %}


Revert to the red line 574 to use the Hugo shortcodes.

mdlinville · 2018-05-17T21:00:18Z

I was wrong about the need to change /docs/ to /content/en/docs/ so you can ignore the request to do that. The things about Hugo shortcodes still need to be addressed.

mdlinville · 2018-05-24T21:58:34Z

Let me get this into a better state.

The feature (was experimental) is dropped in 1.11. xref: kubernetes/kubernetes#58784

mdlinville · 2018-05-24T22:08:21Z

/lgtm
/approve

@tengqm I don't see this in the feature tracking spreadsheet. Should it be there? If so, can you add it and reference this docs PR in the appropriate field? Does it need a release note?

cc/ @idvoretskyi @justaugustus

k8s-ci-robot · 2018-05-24T22:08:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mistyhacks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mistyhacks]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

The feature (was experimental) is dropped in 1.11. xref: kubernetes/kubernetes#58784

* Seperate priority and preemption (#8144) * Doc about PID pressure condition. (#8211) * Doc about PID pressure condition. Signed-off-by: Da K. Ma <[email protected]> * "so" -> "too" * Update version selector for 1.11 * StorageObjectInUseProtection is GA (#8291) * Feature gate: StorageObjectInUseProtection is GA Update feature gate reference for 1.11 * Trivial commit to re-trigger Netlify * CRIContainerLogRotation is Beta in 1.11 (#8665) * Seperate priority and preemption (#8144) * CRIContainerLogRotation is Beta in 1.11 xref: kubernetes/kubernetes#64046 * Bring StorageObjectInUseProtection feature to GA (#8159) * StorageObjectInUseProtection is GA (#8291) * Feature gate: StorageObjectInUseProtection is GA Update feature gate reference for 1.11 * Trivial commit to re-trigger Netlify * Bring StorageObjectInUseProtection feature to GA StorageObjectInUseProtection is Beta in K8s 1.10. It's brought to GA in K8s 1.11. * Fixed typo and added feature state tags. * Remove KUBE_API_VERSIONS doc (#8292) The support to the KUBER_API_VERSIONS environment variable is completely dropped (no deprecation). This PR removes the related doc in release-1.11. xref: kubernetes/kubernetes#63165 * Remove InitialResources from admission controllers (#8293) The feature (was experimental) is dropped in 1.11. xref: kubernetes/kubernetes#58784 * Remove docs related to in-tree support to GPU (#8294) * Remove docs related to in-tree support to GPU The in-tree support to GPU is completely removed in release 1.11. This PR removes the related docs in release-1.11 branch. xref: kubernetes/kubernetes#61498 * Update content updated by PR to Hugo syntax Signed-off-by: Misty Stanley-Jones <[email protected]> * Update the doc about extra volume in kubeadm config (#8453) Signed-off-by: Xianglin Gao <[email protected]> * Update CRD Subresources for 1.11 (#8519) * coredns: update notes in administer-cluster/coredns.md (#8697) CoreDNS is installed by default in 1.11. Add notes on how to install kube-dns instead. Update notes about CoreDNS->CoreDNS upgrades as in 1.11 the Corefile is retained. Add example on upgrading from kube-dns to CoreDNS. * kubeadm-alpha: CoreDNS related changes (#8727) Update note about CoreDNS feature gate. This change also updates a tab as a kubeadm sub-command will change. It looks for a new generated file: generated/kubeadm_alpha_phase_addon_coredns.md instead of: generated/kubeadm_alpha_phase_addon_kube-dns.md * Update cloud controller manager docs to beta 1.11 (#8756) * Update cloud controller manager docs to beta 1.11 * Use Hugo shortcode for feature state * kubeadm-upgrade: include new command `kubeadm upgrade diff` (#8617) Also: - Include note that this was added in 1.11. - Modify the note about upgrade guidance. * independent: update CoreDNS mentions for kubeadm (#8753) Give CoreDNS instead of kube-dns examples in: - docs/setup/independent/create-cluster-kubeadm.md - docs/setup/independent/troubleshooting-kubeadm.md * update 1.11 --server-print info (#8870) * update 1.11 --server-print info * Copyedit * Mark ExpandPersistentVolumes feature to beta (#8778) * Update version selector for 1.11 * Mark ExpandPersistentVolumes Beta xref: kubernetes/kubernetes#64288 * fix shortcode, add placeholder files to fix deploy failures (#8874) * declare ipvs ga (#8850) * kubeadm: update info about CoreDNS in kubeadm-init.md (#8728) Add info to install kube-dns instead of CoreDNS, as CoreDNS is the default DNS server in 1.11. Add notes that kubeadm config images can be used to list and pull the required images in 1.11. * kubeadm: update implementation-details.md about CoreDNS (#8829) - Replace examples from kube-dns to CoreDNS - Add notes about the CoreDNS feature gate status in 1.11 - Add note that the service name for CoreDNS is also called `kube-dns` * Update block device support for 1.11 (#8895) * Update block device support for 1.11 * Copyedits * Fix typo 'fiber channel' (#8957) Signed-off-by: Misty Stanley-Jones <[email protected]> * kubeadm-upgrade: add the 'node [config]' sub-command (#8960) - Add includes for the generated pages - Include placeholder generated pages * kubeadm-init: update the example for the MasterConfiguration (#8958) - include godocs link for MasterConfiguration - include example MasterConfiguration - add note that `kubeadm config print-default` can be used * kubeadm-config: include new commands (#8862) Add notes and includes for these new commands in 1.11: - kubeadm config print-default - kubeadm config migrate - kubeadm config images list - kubeadm config images pull Include placeholder generated files for the above. * administer-cluster/coredns: include more changes (#8985) It was requested that for this page a couple of methods should be outlined: - manual installation for CoreDNS explained at the Kubernetes section of the GitHub project for CoreDNS - installation and upgrade via kubeadm Make the above changes and also add a section "About CoreDNS". This commit also lowercases a section title. * Update CRD subresources doc for 1.11 (#8918) * Add docs for volume expansion and online resizing (#8896) * Add docs for volume expansion going beta * Copyedit * Address feedback * Update exec plugin docs with TLS credentials (#8826) * Update exec plugin docs with TLS credentials kubernetes/kubernetes#61803 implements TLS client credential support for 1.11. * Copyedit * More copyedits for clarification * Additional copyedit * Change token->credential * NodeRestriction admission prevents kubelet taint removal (#8911) * dns-custom-namerserver: break down the page into mutliple sections (#8900) * dns-custom-namerserver: break down the page into mutliple sections This page is currently about kube-dns and is a bit outdated. Introduce the heading `# Customizing kube-dns`. Introduce a separate section about CoreDNS. * Copyedits, fix headings for customizing DNS Hey Lubomir, I coypedited pretty heavily because this workflow is so much easier for docs and because I'm trying to help improve everything touching kubeadm as much as possible. But there's one outstanding issue wrt headings and intro content: you can't add a heading 1 to a topic to do what you wanted to do. The page title in the front matter is rendered as a heading 1 and everything else has to start at heading 2. (We still need to doc this better in the docs contributing content, I know.) Instead, I think we need to rewrite the top-of-page intro content to explain better the relationship between kube-dns and CoreDNS. I'm happy to write something, but I thought I'd push this commit first so you can see what I'm doing. Hope it's all clear -- ping here or on Slack with any questions ~ Jennifer * Interim fix for talking about CoreDNS * Fix CoreDNS details * PSP readOnly hostPath (#8898) * Add documentation for crictl (#8880) * Add documentation for crictl * Copyedit Signed-off-by: Misty Stanley-Jones <[email protected]> * Final copyedit * VolumeSubpathEnvExpansion alpha feature (#8835) * Note that Heapster is deprecated (#8827) * Note that Heapster is deprecated This notes that Heapster is deprecated, and migrates the relevant docs to talk about metrics-server or other solutions by default. * Copyedits and improvements Signed-off-by: Misty Stanley-Jones <[email protected]> * Address feedback * fix shortcode to troubleshoot deploy (#9057) * update dynamic kubelet config docs for v1.11 (#8766) * update dynamic kubelet config docs for v1.11 * Substantial copyedit * Address feedback * Reference doc for kubeadm (release-1.11) (#9044) * Reference doc for kubeadm (release-1.11) * fix shortcode to troubleshoot deploy (#9057) * Reference doc for kube-components (release-1.11) (#9045) * Reference doc for kube-components (release-1.11) * Update cloud-controller-manager.md * fix shortcode to troubleshoot deploy (#9057) * Documentation on lowercasing kubeadm init apiserver SANs (#9059) * Documentation on lowercasing kubeadm init apiserver SANs * fix shortcode to troubleshoot deploy (#9057) * Clarification in dynamic Kubelet config doc (#9061) * Promote sysctls to Beta (#8804) * Promote sysctls to Beta * Copyedits Signed-off-by: Misty Stanley-Jones <[email protected]> * Review comments * Address feedback * More feedback * kubectl reference docs for 1.11 (#9080) * Update Kubernetes API 1.11 ref docs (#8977) * Update v1alpha1 to v1beta1. * Adjust left nav for 1.11 ref docs. * Trim list of old ref docs. * Update Federation API ref docs for 1.11. (#9064) * Update Federation API ref docs for 1.11. * Add titles. * Update definitions.html * CRD versioning Public Documentation (#8834) * CRD versioning Public Documentation * Copyedit Signed-off-by: Misty Stanley-Jones <[email protected]> * Address feedback * More rewrites * Address feedback * Update main CRD page in light of versioning * Reorg CRD docs * Further reorg * Tweak title * CSI documentation update for raw block volume support (#8927) * CSI documetation update for raw block volume support * minor edits for "CSI raw block volume support" Some small grammar and style nits. * minor CSIBlockVolume edits * Update kubectl component ref page for 1.11. (#9094) * Update kubectl component ref page for 1.11. * Add title. Replace stevepe with username. * crd versioning doc: fix nits (#9142) * Update `DynamicKubeletConfig` feature to beta (#9110) xref: kubernetes/kubernetes#64275 * Documentation for dynamic volume limits based on node type (#8871) * add cos for storage limits * Update docs specific for aws and gce * fix some minor things * Update storage-limits.md * Add k8s version to feature-state shortcode * The Doc update for ScheduleDaemonSetPods (#8842) Signed-off-by: Da K. Ma <[email protected]> * Update docs related to PersistentVolumeLabel admission control (#9109) The said admission controller is disabled by default in 1.11 (kubernetes/kubernetes#64326) and scheduled to be removed in future release. * client exec auth: updates for 1.11 (#9154) * Updates HA kubeadm docs (#9066) * Updates HA kubeadm docs Signed-off-by: Chuck Ha <[email protected]> * kubeadm HA - Add stacked control plane steps * ssh instructions and some typos in the bash scripts Signed-off-by: Chuck Ha <[email protected]> * Fix typos and copypasta errors * Fix rebase issues * Integrate more changes Signed-off-by: Chuck Ha <[email protected]> * copyedits, layout and formatting fixes * final copyedits * Adds a sanity check for load balancer connection Signed-off-by: Chuck Ha <[email protected]> * formatting fixes, copyedits * fix typos, formatting * Document the Pod Ready++ feature (#9180) Closes: #9107 Xref: kubernetes/kubernetes#64057 * Mention 'KubeletPluginsWatcher' feature (#9177) * Mention 'KubeletPluginsWatcher' feature This feature is more developers oriented than users oriented, so simply mention it in the feature gate should be fine. In future, when the design doc is migrated from Google doc to the kubernetes/community repo, we can add links to it for users who want to dig deeper. Closes: #9108 Xref: kubernetes/kubernetes#63328, kubernetes/kubernetes#64605 * Copyedit * Amend dynamic volume list docs (#9181) The dynamic volume list feature has been documented but the feature gate related was not there yet. Closes: #9105 * Document for service account projection (#9182) This adds docs for the service account projection feature. Xref: kubernetes/kubernetes#63819, kubernetes/community#1973 Closes: #9102 * Update pod priority and preemption user docs (#9172) * Update pod priority and preemption user docs * Copyedit * Documentation on setting node name with Kubeadm (#8925) * Documentation on setting node name with Kubeadm * copyedit * Add kubeadm upgrade docs for 1.11 (#9089) * Add kubeadm upgrade docs for 1.11 * Initial docs review feedback * Add 1-11 to outline * Fix formatting on tab blocks * Move file to correct location * Add `kubeadm upgrade node config` step * Overzealous ediffing * copyedit, fix lists and headings * clarify --force flag for fixing bad state * Get TOML ready for 1.11 release * Blog post for 1.11 release (#9254) * Blog post for 1.11 release * Update 2018-06-26-kubernetes-1.11-release-announcement.md * Update 2018-06-26-kubernetes-1.11-release-announcement.md * Update 2018-06-26-kubernetes-1.11-release-announcement.md

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 3, 2018

k8s-ci-robot requested review from lavalamp and thockin May 3, 2018 07:23

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 3, 2018

k8s-ci-robot requested a review from mdlinville May 11, 2018 18:48

mdlinville force-pushed the release-1.11 branch from 8cc303d to 6cba902 Compare May 16, 2018 03:08

mdlinville force-pushed the rm-initialresources branch from 1ff971d to 020dfcb Compare May 16, 2018 22:45

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 16, 2018

mdlinville added this to the 1.11 milestone May 16, 2018

mdlinville suggested changes May 16, 2018

View reviewed changes

k8s-ci-robot assigned chenopis May 16, 2018

mdlinville force-pushed the release-1.11 branch from 5647835 to 8594900 Compare May 24, 2018 20:43

mdlinville force-pushed the rm-initialresources branch from 020dfcb to 4535137 Compare May 24, 2018 22:01

Remove InitialResources from admission controllers

3248120

The feature (was experimental) is dropped in 1.11. xref: kubernetes/kubernetes#58784

mdlinville force-pushed the rm-initialresources branch from 4535137 to 3248120 Compare May 24, 2018 22:04

k8s-ci-robot assigned mdlinville May 24, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2018

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2018

k8s-ci-robot merged commit e067cde into kubernetes:release-1.11 May 24, 2018

tengqm deleted the rm-initialresources branch May 29, 2018 04:59

k82cn pushed a commit to k82cn/website that referenced this pull request Jun 11, 2018

Remove InitialResources from admission controllers (kubernetes#8293)

2438f6d

The feature (was experimental) is dropped in 1.11. xref: kubernetes/kubernetes#58784

mdlinville pushed a commit that referenced this pull request Jun 20, 2018

Remove InitialResources from admission controllers (#8293)

aef727b

The feature (was experimental) is dropped in 1.11. xref: kubernetes/kubernetes#58784

mdlinville pushed a commit that referenced this pull request Jun 27, 2018

Remove InitialResources from admission controllers (#8293)

ba4494e

The feature (was experimental) is dropped in 1.11. xref: kubernetes/kubernetes#58784

mdlinville pushed a commit that referenced this pull request Jun 27, 2018

Remove InitialResources from admission controllers (#8293)

88e0fba

The feature (was experimental) is dropped in 1.11. xref: kubernetes/kubernetes#58784

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove InitialResources from admission controllers #8293

Remove InitialResources from admission controllers #8293

tengqm commented May 3, 2018

k8sio-netlify-preview-bot commented May 3, 2018 •

edited

Loading

zacharysarah commented May 11, 2018

mdlinville commented May 16, 2018

mdlinville left a comment

mdlinville May 16, 2018

mdlinville May 16, 2018

mdlinville May 16, 2018

mdlinville May 16, 2018

mdlinville commented May 17, 2018

mdlinville commented May 24, 2018

mdlinville commented May 24, 2018 •

edited

Loading

k8s-ci-robot commented May 24, 2018

Remove InitialResources from admission controllers #8293

Remove InitialResources from admission controllers #8293

Conversation

tengqm commented May 3, 2018

k8sio-netlify-preview-bot commented May 3, 2018 • edited Loading

zacharysarah commented May 11, 2018

mdlinville commented May 16, 2018

mdlinville left a comment

Choose a reason for hiding this comment

mdlinville May 16, 2018

Choose a reason for hiding this comment

mdlinville May 16, 2018

Choose a reason for hiding this comment

mdlinville May 16, 2018

Choose a reason for hiding this comment

mdlinville May 16, 2018

Choose a reason for hiding this comment

mdlinville commented May 17, 2018

mdlinville commented May 24, 2018

mdlinville commented May 24, 2018 • edited Loading

k8s-ci-robot commented May 24, 2018

k8sio-netlify-preview-bot commented May 3, 2018 •

edited

Loading

mdlinville commented May 24, 2018 •

edited

Loading