Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Amadeus #7815

Closed
wants to merge 1 commit into from
Closed

Add Amadeus #7815

wants to merge 1 commit into from

Conversation

alexcontini
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 22, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 92c7dec

https://deploy-preview-7815--kubernetes-io-master-staging.netlify.com

tengqm
tengqm approved these changes Mar 23, 2018
View reviewed changes
Copy link
Contributor

@tengqm tengqm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tengqm
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: a-mccarthy

Assign the PR to them by writing /assign @a-mccarthy in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@heckj
Copy link
Contributor

heckj commented Mar 23, 2018

/retest

@heckj
Copy link
Contributor

heckj commented Mar 23, 2018

I'm not sure if there's a way to re-trigger the netlify deploy from comments - an image was missing, but I just merged it in another PR, wanted to trigger the netlify thing to rebuild if i could...

@heckj
Copy link
Contributor

heckj commented Mar 23, 2018

Okay - that's not working. @alexcontini I'm sorry to ask this, but would you mind rebasing or adding something trivial to this to retrigger a netlify push with an updated merge against the master branch?

@heckj
Copy link
Contributor

heckj commented Mar 23, 2018

closing in favor of #7827

@heckj heckj closed this Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm approved these changes

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

Assignees

@tengqm tengqm

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexcontini @k8sio-netlify-preview-bot @k8s-ci-robot @heckj @tengqm