New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes to kubeadm 1.8 upgrade guide. #5678

Merged

steveperry-53 merged 1 commit into kubernetes:release-1.8 from pipejakob:kubeadm-upgrade-1.8

Sep 28, 2017

Contributor

pipejakob commented Sep 28, 2017 •

edited

Loading

A few minor changes to the kubeadm 1.8 upgrade guide, as discussed on #sig-cluster-lifecycle on Slack.

The kubelet upgrade instructions should be done on every host, not just worker nodes.
We should just upgrade all packages, instead of calling out kubelet specifically. This will also upgrade kubectl, kubeadm, and kubernetes-cni, if installed.
Draining nodes should also ignore daemonsets, and master errors can be ignored.
Make sure that the new kubeadm download is chmoded correctly.
Add a step to run kubeadm version to verify after downloading.
Manually approve new kubelet CSRs if rotation is enabled (known issue).

CC @kubernetes/sig-cluster-lifecycle-bugs @luxas @timothysc

This change is

k8s-ci-robot added size/M cncf-cla: yes labels

k8s-github-robot assigned Bradamant3

Collaborator

k8sio-netlify-preview-bot commented Sep 28, 2017 •

edited

Loading

Deploy preview ready!

Built with commit 087ccce

https://deploy-preview-5678--kubernetes-io-vnext-staging.netlify.com

Contributor Author

pipejakob commented Sep 28, 2017

I posted this for early feedback from devs, but there are a few more fixes to this doc on their way that I'll keep adding to this PR. Feel free to ignore Docs Review until it's actually complete.

pipejakob force-pushed the kubeadm-upgrade-1.8 branch 2 times, most recently from f081be8 to 47751a5 Compare

September 28, 2017 21:20

steveperry-53 self-assigned this

steveperry-53 added the Tech Review: Open Issues label

pipejakob force-pushed the kubeadm-upgrade-1.8 branch from 47751a5 to 5f725c3 Compare

September 28, 2017 21:29

Contributor Author

pipejakob commented Sep 28, 2017

I believe the PR is complete and ready for review now, for the known issues that were found in this guide.

luxas reviewed

View reviewed changes

Member

luxas left a comment

Minor nits, but please fix some of them at least

docs/tasks/administer-cluster/kubeadm-upgrade-1-8.md Outdated

+. Prepare the host for maintenance, marking it unschedulable and evicting the workload:
+              ```shell
+              $ kubectl cordon $HOST

Member

luxas Sep 28, 2017

Checked now that drain cordons as well, so this is not strictly needed, nit

Contributor Author

pipejakob Sep 28, 2017

Done.

docs/tasks/administer-cluster/kubeadm-upgrade-1-8.md Outdated

    
              1. Prepare the node for maintenance, marking it unschedulable and evicting the workload:

              When running `kubectl drain` against the master host, this error is expected and can be safely ignored:

Member

luxas Sep 28, 2017

(As there are Static Pods on the master)
Add that if you like

Contributor Author

pipejakob Sep 28, 2017

Done.

docs/tasks/administer-cluster/kubeadm-upgrade-1-8.md Outdated

               ```shell
               $ yum update
-              $ yum install -y kubelet
+              $ yum upgrade

Member

luxas Sep 28, 2017

Is this the right command? I'm not familiar with it, but thought yum update also upgrades packages...

Contributor Author

pipejakob Sep 28, 2017

I wasn't quite sure. In my testing, it seems that yum update is all that's necessary, but I'd love for an expert to chime in. @timothysc, what do you think?

I've optimistically cut it down to just yum update for now.

docs/tasks/administer-cluster/kubeadm-upgrade-1-8.md Outdated

               ```shell
               $ systemctl status kubelet
               ```
-. Bring the `$WORKER` node back online by marking it schedulable:
+. If certificate rotation is enabled, you may need to manually approve the new kubelet's CertificateSigningRequest before it can rejoin the cluster:

Member

luxas Sep 28, 2017

Which it unconditionally is :P
You can remove the if clause

Contributor Author

pipejakob Sep 28, 2017

Yeah, I was trying to accommodate for the potential of users manually editing and overriding these settings, but you're right that it's definitely the default behavior now. I've reworded this, but am open to more changes to make it as understandable as possible.

docs/tasks/administer-cluster/kubeadm-upgrade-1-8.md Outdated

@@ @@ -195,52 +202,74 @@ $ kubeadm upgrade apply v1.8.0 @@
                  find your CNI provider and see if there are additional upgrade steps
                  necessary.
-              ## Upgrading your worker nodes
+              ## Upgrading your master and nodes

Member

luxas Sep 28, 2017

Upgrading master and node packages?

Contributor Author

pipejakob Sep 28, 2017

Done.

steveperry-53 added Docs LGTM and removed Tech Review: Open Issues labels


          Minor fixes to kubeadm 1.8 upgrade guide.

087ccce

- The kubelet upgrade instructions should be done on every host, not
  just worker nodes.
- We should just upgrade all packages, instead of calling out kubelet
  specifically. This will also upgrade kubectl, kubeadm, and
  kubernetes-cni, if installed.
- Draining nodes should also ignore daemonsets, and master errors can be
  ignored.
- Make sure that the new kubeadm download is chmoded correctly.
- Add a step to run `kubeadm version` to verify after downloading.
- Manually approve new kubelet CSRs if rotation is enabled (known issue).

pipejakob force-pushed the kubeadm-upgrade-1.8 branch from 5f725c3 to 087ccce Compare

September 28, 2017 21:53

Contributor Author

pipejakob commented Sep 28, 2017

I think I've addressed all of the comments. Care to take another look?

Contributor Author

pipejakob commented Sep 28, 2017

From @luxas on Slack:

Heading to bed now, very late & school. I left comments on the doc, fixup some small nits and LGTM
You don't need a second explicit approval, just go ahead after this

I'm still open to any other feedback from devs or docs, but that sounds like an LGTM from @luxas.

steveperry-53 added Tech Review LGTM and removed Tech Review: Open Issues labels

Contributor

steveperry-53 commented Sep 28, 2017

@pipejakob That sounds like a tech lgtm to me. Are you ready for me to merge this now?

Contributor Author

pipejakob commented Sep 28, 2017

@steveperry-53 Yes, please. Thank you!

steveperry-53 merged commit 0ab8fd0 into kubernetes:release-1.8

pipejakob mentioned this pull request

CertificateManager blocks kubelet start if auto-approval is not enabled kubernetes/kubernetes#53237

Closed

steveperry-53 added a commit that referenced this pull request


          Release 1.8 (#5659)

799eaf4

* GC now supports non-core resources

* Add two examples about how to analysis audits of kube-apiserver (#4264)

* Deprecate system:nodes binding

* [1.8] StatefulSet `initialized` annotation is now ignored.

* inits the kubeadm upgrade docs

addresses /issues/4689

* adds kubeadm upgrade cmd to ToC

addresses /issues/4689

* add workload placement docs

* ScaleIO - document udpate for 1.8

* Add documentation on storageClass.mountOptions and PV.mountOptions (#5254)

* Add documentation on storageClass.mountOptions and PV.mountOptions

* convert notes into callouts

* Add docs for CustomResource validation

add info about supported fields

* advanced audit beta features (#5300)

* Update job workload doc with backoff failure policy (#5319)

Add to the Jobs documentation how to use the new backoffLimit field that
limit the number of Pod failure before considering the Job as failed.

* Documented additional AWS Service annotations (#4864)

* Add device plugin doc under concepts/cluster-administration. (#5261)

* Add device plugin doc under concepts/cluster-administration.

* Update device-plugins.md

* Update device-plugins.md

Add meta description. Fix typo. Change bare metal deployment to manual deployment.

* Update device-plugins.md

Fix typo again.

* Update page.version. (#5341)

* Add documentation on storageClass.reclaimPolicy (#5171)

* [Advanced audit] use new herf for audit-api (#5349)

This tag contains all the changes in v1beta1 version. Update it now.

* Added documentation around creating the InitializerConfiguration for the persistent volume label controller in the cloud-controller-manager (#5255)

* Documentation for kubectl plugins (#5294)

* Documentation for kubectl plugins

* Update kubectl-plugins.md

* Update kubectl-plugins.md

* Updated CPU manager docs to match implementation. (#5332)

* Noted limitation of alpha static cpumanager.

* Updated CPU manager docs to match implementation.

- Removed references to CPU pressure node condition and evictions.
- Added note about new --cpu-manager-reconcile-period flag.
- Added note about node allocatable requirements for static policy.
- Noted limitation of alpha static cpumanager.

* Move cpu-manager task link to rsc mgmt section.

* init containers annotation removed in  1.8 (#5390)

* Add documentation for TaintNodesByCondition (#5352)

* Add documentation for TaintNodesByCondition

* Update nodes.md

* Update taint-and-toleration.md

* Update daemonset.md

* Update nodes.md

* Update taint-and-toleration.md

* Update daemonset.md

* Fix deployments (#5421)

* Document extended resources and OIR deprecation. (#5399)

* Document extended resources and OIR deprecation.

* Updated extended resources doc per reviews.

* reverts extra spacing in _data/tasks.yml

* addresses `kubeadm upgrade` review comments

Feedback from @chenopis, @luxas, and @steveperry-53 addressed with this commit

* HugePages documentation (#5419)

* Update cpu-management-policies.md (#5407)

Fixed the bad link.
Modified "cpu" to "CPU".
Added more 'yaml' as supplement.

* Update RBAC docs for v1 (#5445)

* Add user docs for pod priority and preemption (#5328)

* Add user docs for pod priority and preemption

* Update pod-priority-preemption.md

* More updates

* Update docs/admin/kubeadm.md for 1.8 (#5440)

- Made a couple of minor wording changes (not strictly 1.8 related).
 - Did some reformatting (not strictly 1.8 related).
 - Updated references to the default token TTL (was infinite, now 24 hours).
 - Documented the new `--discovery-token-ca-cert-hash` and `--discovery-token-unsafe-skip-ca-verification` flags for `kubeadm join`.
 - Added references to the new `--discovery-token-ca-cert-hash` flag in all the default examples.
 - Added a new _Security model_ section that describes the security tradeoffs of the various discovery modes.
 - Documented the new `--groups` flag for `kubeadm token create`.
 - Added a note of caution under _Automating kubeadm_ that references the _Security model_ section.
 - Updated the component version table to drop 1.6 and add 1.8.
 - Update `_data/reference.yml` to try to get the sidebar fixed up and more consistent with `kubefed`.

* Update StatefulSet Basics for 1.8 release (#5398)

* addresses `kubeadm upgrade` review comments

2nd iteration review comments by @luxas

* adds kubelet upgrade section to kubeadm upgrade

* Fix a bulleted list on docs/admin/kubeadm.md. (#5458)

I updated this doc yesterday and I was absolutely sure I fixed this, but I just saw that this commit got lost somehow.

This was introduced recently in #5440.

* Clarify the API to check for device plugins

* Moving Flexvolume to separate out-of-tree section

* addresses `kubeadm upgrade` review comments

CC: @luxas

* fixes kubeadm upgrade index

* Update Stackdriver Logging documentation (#5495)

* Re-update WordPress and MySQL PV doc to use apps/v1beta2 APIs (#5526)

* Update statefulset concepts doc to use apps/v1beta2 APIs (#5420)

* add document on kubectl's behavior regarding initializers (#5505)

* Update docs/admin/kubeadm.md to cover self-hosting in 1.8. (#5497)

This is a new beta feature in 1.8.

* Update kubectl patch doc to use apps/v1beta2 APIs (#5422)

* [1.8] Update "Run Applications" tasks to apps/v1beta2. (#5525)

* Update replicated stateful application task for 1.8.

* Update single instance stateful app task for 1.8.

* Update stateless app task for 1.8.

* Update kubectl patch task for 1.8.

* fix the link of persistent storage (#5515)

* update the admission-controllers.md index.md what-is-kubernetes.md link

* fix the link of persistent storage

* Add quota support for local ephemeral storage (#5493)

* Add quota support for local ephemeral storage

update the doc to this alpha feature

* Update resource-quotas.md

* Updated Deployments concepts doc (#5491)

* Updated Deployments concepts doc

* Addressed comments

* Addressed more comments

* Modify allocatable storage to ephemeral-storage (#5490)

Update the doc to use ephemeral-storage instead of storage

* Revamped concepts doc for ReplicaSet (#5463)

* Revamped concepts doc for ReplicaSet

* Minor changes to call out specific versions for selector defaulting and
immutability

* Addressed doc review comments

* Remove petset documentations (#5395)

* Update docs to use batch/v1beta1 cronjobs (#5475)

* add federation job doc (#5485)

* add federation job doc

* Update job.md

Edits for clarity and consistency

* Update job.md

Fixed a typo

* update DaemonSet concept for 1.8 release (#5397)

* update DaemonSet concept for 1.8 release

* Update daemonset.md

Fix typo. than -> then

* Update bootstrap tokens doc for 1.8. (#5479)

* Update bootstrap tokens doc for 1.8.

This has some changes I missed when I was updating the main kubeadm documention:
 - Bootstrap tokens are now beta, not alpha (kubernetes/enhancements#130)
 - The apiserver flag to enable the authenticator changedin 1.8 (kubernetes/kubernetes#51198)
 - Added `auth-extra-groups` documentaion (kubernetes/kubernetes#50933)
 - Updated the _Token Management with `kubeadm`_ section to link to the main kubeadm docs, since it was just duplicated information.

* Update bootstrap-tokens.md

* Updated the Cassandra tutorial to use apps/v1beta2 (#5548)

* add docs for AllowPrivilegeEscalation (#5448)

Signed-off-by: Jess Frazelle <[email protected]>

* Add local ephemeral storage alpha feature in managing compute resource (#5522)

* Add local ephemeral storage alpha feature in managing compute resource

Since 1.8, we add the local ephemeral storage alpha feature as one
resource type to manage. Add this feature into the doc.

* Update manage-compute-resources-container.md

* Update manage-compute-resources-container.md

* Update manage-compute-resources-container.md

* Update manage-compute-resources-container.md

* Update manage-compute-resources-container.md

* Update manage-compute-resources-container.md

* Added documentation for Metrics Server (#5560)

* authorization: improve authorization debugging docs (#5549)

* Document mount propagation (#5544)

* Update /docs/setup/independent/create-cluster-kubeadm.md for 1.8. (#5524)

This introduction needed a couple of small tweaks to cover the `--discovery-token-ca-cert-hash` flag added in kubernetes/kubernetes#49520 and some version bumps.

* Add task doc for alpha dynamic kubelet configuration (#5523)

* Fix input/output of selfsubjectaccess review (#5593)

* Add docs for implementing resize (#5528)

* Add docs for implementing resize

* Update admission-controllers.md

* Added link to PVC section

* minor typo fixes

* Update NetworkPolicy concept guide with egress and CIDR changes (#5529)

* update zookeeper tutorial for 1.8 release

* add doc for hostpath type (#5503)

* Federated Hpa feature doc (#5487)

* Federated Hpa feature doc

* Federated Hpa feature doc review fixes

* Update hpa.md

* Update hpa.md

* update cloud controller manager docs for v1.8

* Update cronjob with defaults information (#5556)

* Kubernetes 1.8 reference docs (#5632)

* Kubernetes 1.8 reference docs

* Kubectl reference docs for 1.8

* Update side bar with 1.8 kubectl and api ref docs links

* remove petset.md

* update on state of HostAlias in 1.8 with hostNetwork Pod support (#5644)

* Fix cron job deletion section (#5655)

* update imported docs (#5656)

* Add documentation for certificate rotation. (#5639)

* Link to using kubeadm page

* fix the command output

fix the command output

* fix typo in api/resources reference: "Worloads"

* Add documentation for certificate rotation.

* Create TOC entry for cloud controller manager. (#5662)

* Updates for new versions of API types

* Followup 5655: fix link to garbage collection (#5666)

* Temporarily redirect resources-reference to api-reference. (#5668)

* Update config for 1.8 release. (#5661)

* Update config for 1.8 release.

* Address reviewer comments.

* Switch references in HPA docs from alpha to beta (#5671)

The HPA docs still referenced the alpha version.  This switches them to
talk about v2beta1, which is the appropriate version for Kubernetes 1.8

* Deprecate openstack heat (#5670)

* Fix typo in pod preset conflict example

Move container port definition to the correct line.

* Highlight openstack-heat provider deprecation

The openstack-heat provider for kube-up is being deprecated and will be
removed in a future release.

* Temporarily fix broken links by redirecting. (#5672)

* Fix broken links. (#5675)

* Fix render of code block (#5674)

* Fix broken links. (#5677)

* Add a small note about auto-bootstrapped CSR ClusterRoles (#5660)

* Update kubeadm install doc for v1.8 (#5676)

* add draft workloads api content for 1.8 (#5650)

* add draft workloads api content for 1.8

* edits per review, add tables, for 1.8 workloads api doc

* fix typo

* Minor fixes to kubeadm 1.8 upgrade guide. (#5678)

- The kubelet upgrade instructions should be done on every host, not
  just worker nodes.
- We should just upgrade all packages, instead of calling out kubelet
  specifically. This will also upgrade kubectl, kubeadm, and
  kubernetes-cni, if installed.
- Draining nodes should also ignore daemonsets, and master errors can be
  ignored.
- Make sure that the new kubeadm download is chmoded correctly.
- Add a step to run `kubeadm version` to verify after downloading.
- Manually approve new kubelet CSRs if rotation is enabled (known issue).

* Release 1.8 (#5680)

* Fix versions for 1.8 API ref docs

* Updates for 1.8 kubectl reference docs

* Kubeadm /docs/admin/kubeadm.md cleanup, editing. (#5681)

* Update docs/admin/kubeadm.md (mostly 1.8 related).

This is Fabrizio's work, which I'm committing along with my edits (in a commit on top of this).

* A few of my own edits to clarify and clean up some Markdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes size/M