Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update zookeeper tutorial for 1.8 release #5496

Merged
merged 1 commit into from
Sep 25, 2017
Merged

update zookeeper tutorial for 1.8 release #5496

merged 1 commit into from
Sep 25, 2017

Conversation

kow3ns
Copy link
Member

@kow3ns kow3ns commented Sep 15, 2017 •
edited by k8s-reviewable
Loading

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 15, 2017
@kow3ns kow3ns mentioned this pull request Sep 15, 2017
Closed
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Sep 15, 2017 •
edited
Loading

Deploy preview ready!

Built with commit 5dc6316

https://deploy-preview-5496--kubernetes-io-vnext-staging.netlify.com

@chenopis
Copy link
Contributor

@kow3ns The Travis check is failing:

[0K$ go test -v k8s.io/kubernetes.github.io/test
=== RUN TestExampleObjectSchemas
--- FAIL: TestExampleObjectSchemas (0.13s)
examples_test.go:369: skipping : ../docs/user-guide/petset.yaml/petset
examples_test.go:386: ../docs/tutorials/stateful-application/zookeeper.yaml did not decode correctly: converting (v1.Service) to (api.ConfigMap): Data not present in src
{"apiVersion":"v1","kind":"Service","metadata":{"labels":{"app":"zk"},"name":"zk-cs"},"spec":{"ports":[{"name":"client","port":2181}],"selector":{"app":"zk"}}}
examples_test.go:399: Directory ../docs/tutorials/stateful-application: Expected 10 examples, Got 6

@steveperry-53 steveperry-53 added this to the 1.8 milestone Sep 18, 2017
@steveperry-53
Copy link
Contributor

@foxish, Will you be able to do the tech review for this?
@chenopis, OK to set Docs LGTM?

@janetkuo janetkuo self-assigned this Sep 25, 2017
@kow3ns
Copy link
Member Author

kow3ns commented Sep 25, 2017

@steveperry-53 @foxish is busy with the @janetkuo has volunteered to review. Thanks.

janetkuo
janetkuo reviewed Sep 25, 2017
View reviewed changes
docs/tutorials/stateful-application/zookeeper.md Outdated
service "zk-headless" created
configmap "zk-config" created
service "zk-hs" created
service "zk-cs" created
poddisruptionbudget "zk-budget" created
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"zk-pdb"

docs/tutorials/stateful-application/zookeeper.md Outdated
You can use `kubectl patch` to update the number of `cpus` allocated to the servers.

```shell{% raw %}
kubectl patch sts zk --type='json' -p='[{"op": "replace", "path": "/spec/template/spec/containers/0/resources/requests/cpu", "value":"0.3"}]'statefulset "zk" patched
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

statefulset "zk" patched should be a separate line

docs/tutorials/stateful-application/zookeeper.md Outdated

Use `kubectl rollout status` to watch the status of the update.

``shell
Copy link
Member

@janetkuo janetkuo Sep 25, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ```shell

docs/tutorials/stateful-application/zookeeper.md Outdated
The `min-available` field indicates to Kubernetes that at least two Pods from
`zk` StatefulSet must be available at any time.
The `max-unavailable` field indicates to Kubernetes that at most one Pod from
`zk` StatefulSet must be unavailable at any time.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

must be unavailable --> can be unavailable

docs/tutorials/stateful-application/zookeeper.md Outdated
zk-budget 2 1 1h
```shell
NAME MIN-AVAILABLE MAX-UNAVAILABLE ALLOWED-DISRUPTIONS AGE
zk-pdb N/A 1 1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this new line

@steveperry-53
Copy link
Contributor

@janetkuo @kow3ns We're getting this error in the Travis CI build:

go test -v k8s.io/kubernetes.github.io/test
=== RUN TestExampleObjectSchemas
--- FAIL: TestExampleObjectSchemas (0.17s)
examples_test.go:385: ../docs/tutorials/stateful-application/zookeeper.yaml did not decode correctly: converting (v1.Service) to (api.ConfigMap): Data not present in src
{"apiVersion":"v1","kind":"Service","metadata":{"labels":{"app":"zk"},"name":"zk-cs"},"spec":{"ports":[{"name":"client","port":2181}],"selector":{"app":"zk"}}}
examples_test.go:398: Directory ../docs/tutorials/stateful-application: Expected 10 examples, Got 6

@kow3ns
Copy link
Member Author

kow3ns commented Sep 25, 2017

yeah somehow my modifications to test/examples_test.go got dropped on a rebase ... should be fixed now

@chenopis chenopis merged commit 532c60d into kubernetes:release-1.8 Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janetkuo janetkuo janetkuo approved these changes

@foxish foxish Awaiting requested review from foxish

Assignees

@janetkuo janetkuo

@chenopis chenopis

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.8
Development

Successfully merging this pull request may close these issues.
6 participants
@kow3ns @k8sio-netlify-preview-bot @chenopis @steveperry-53 @janetkuo @k8s-ci-robot