Improve host aliases page #5443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
Deploy preview ready! Built with commit 5a6f947 https://deploy-preview-5443--kubernetes-io-master-staging.netlify.com |
|
@xiangpengzhao Could you help me to review this changes? |
|
ping @rickypai who is the author of this doc for reviewing :) |
|
/lgtm |
|
@rickypai: changing LGTM is restricted to assignees, and only kubernetes org members may be assigned issues. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
evie404
reviewed
Sep 14, 2017
| $ kubectl apply -f hostaliases-pod.yaml | ||
| pod "hostaliases-pod" created | ||
|
|
||
| $ kubectl get pod -a |
There was a problem hiding this comment.
can you do -o=wide here so it prints out the pod IP. that way the IP of this entry
10.244.3.80 hostaliases-pod
becomes clearer
|
thanks for fixing this btw |
|
@xiangpengzhao Thanks you for your help!! |
|
@rickypai I added wide output, thanks you for review. |
|
@rickypai Could you help me to review again? |
|
I think this is good to go. |
chenopis
added a commit
that referenced
this pull request
Sep 16, 2017
…hub.io into release-1.8 * 'master' of https://github.com/kubernetes/kubernetes.github.io: ZTE-SH-CN-debug-pod-replication-controller-2017-09-14-14 ZTE-SH-CN-define-command-argument-container (#5381) Update index.md Update Kompose docs Improve host aliases page (#5443) Add link to AlwaysPullImages admission controller Revert "create homepage for user journeys" create homepage for user journeys fix the command output ZTE-SH-CN-run-application-run-single-instance-stateful-application-pr-2017-… (#5363) Add a note to static pod manifest scanning revert WordPress and MySQL PV doc changes to use apps/v1beta2 APIs (#5461) Fix pod probes yaml file Redirect v1 docs. (#5460) Fix error link (#5459) Fix typo in deployment documentation # Conflicts: # docs/tutorials/stateful-application/basic-stateful-set.md
chenopis
added a commit
that referenced
this pull request
Sep 16, 2017
…hub.io into release-1.7 * 'master' of https://github.com/kubernetes/kubernetes.github.io: ZTE-SH-CN-debug-pod-replication-controller-2017-09-14-14 ZTE-SH-CN-define-command-argument-container (#5381) Update index.md Update Kompose docs Improve host aliases page (#5443) Add link to AlwaysPullImages admission controller Revert "create homepage for user journeys" create homepage for user journeys fix the command output ZTE-SH-CN-run-application-run-single-instance-stateful-application-pr-2017-… (#5363) Add a note to static pod manifest scanning revert WordPress and MySQL PV doc changes to use apps/v1beta2 APIs (#5461) Fix pod probes yaml file Redirect v1 docs. (#5460) Fix error link (#5459) Fix typo in deployment documentation
chenopis
added a commit
that referenced
this pull request
Sep 18, 2017
…hub.io into chenopis-404-20170915 * 'master' of https://github.com/kubernetes/kubernetes.github.io: Adding Treasure Data to KCSP page (#5488) Update docs/admin/authentication.md (#5408) ZTE-SH-CN-debug-pod-replication-controller-2017-09-14-14 ZTE-SH-CN-define-command-argument-container (#5381) Update index.md Update Kompose docs Improve host aliases page (#5443) Add link to AlwaysPullImages admission controller
chenopis
added a commit
that referenced
this pull request
Sep 19, 2017
…hub.io into chenopis-user-journeys * 'master' of https://github.com/kubernetes/kubernetes.github.io: (21 commits) Remove User FAQ refer links (#5467) fix link of secret ZTE-SH-CN-debug-stateful-set-2017-09-19 use para. page.version to replace specific version update the admission-controllers.md index.md what-is-kubernetes.md link Fix incorrect links update aggregated-api-servers.md link update api-group link fix version.md link Monthly 404 fix (#5494) Fix spelling mistake. Adding Treasure Data to KCSP page (#5488) Update docs/admin/authentication.md (#5408) ZTE-SH-CN-debug-pod-replication-controller-2017-09-14-14 ZTE-SH-CN-define-command-argument-container (#5381) Update index.md Update Kompose docs Improve host aliases page (#5443) Add link to AlwaysPullImages admission controller Revert "create homepage for user journeys" ... # Conflicts: # docs/home/index.md
2 tasks
jesscodez
pushed a commit
that referenced
this pull request
Sep 22, 2017
* Fix confusion code block * Add more detail command * Add pod wide output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #5442. Add more detail command, and fix confusion code block.
This change is