Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-3221: remove mentions of beta and featuregate, and change order of cmd line #48487

Merged
merged 1 commit into from
Nov 19, 2024
Merged

KEP-3221: remove mentions of beta and featuregate, and change order of cmd line #48487

merged 1 commit into from
Nov 19, 2024

Conversation

ritazh
Copy link
Member

@ritazh ritazh commented Oct 22, 2024

…f cmd line

Description

remove mentions of beta and featuregate, and change order of cmd line kubernetes/enhancements#3221

Issue

Closes: #

/sig auth
/cc @liggitt @palnabarun

@k8s-ci-robot k8s-ci-robot added this to the 1.32 milestone Oct 22, 2024
@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 22, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 22, 2024 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 7d8b07e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/67187bef0c37230008ac5be0

liggitt
liggitt reviewed Oct 22, 2024
View reviewed changes
content/en/docs/reference/access-authn-authz/authorization.md Outdated
<!-- keep legacy hyperlinks working -->
<a id="configuring-the-api-server-using-an-authorization-config-file" />

### Configuring the API Server using an authorization config file {#using-configuration-file-for-authorization}

{{< feature-state feature_gate_name="StructuredAuthorizationConfiguration" >}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this pulls the info from the feature gate file, no need to hard-code stable / 1.32

content/en/docs/reference/command-line-tools-reference/kube-apiserver.md Outdated
@@ -344,7 +344,7 @@ kube-apiserver [flags]
<td colspan="2">--authorization-config string</td>
</tr>
<tr>
<td></td><td style="line-height: 130%; word-wrap: break-word;"><p>File with Authorization Configuration to configure the authorizer chain.Note: This feature is in Alpha since v1.29.--feature-gate=StructuredAuthorizationConfiguration=true feature flag needs to be set to true for enabling the functionality.This feature is mutually exclusive with the other --authorization-mode and --authorization-webhook-* flags.</p></td>
<td></td><td style="line-height: 130%; word-wrap: break-word;"><p>File with Authorization Configuration to configure the authorizer chain. This feature is mutually exclusive with the other --authorization-mode and --authorization-webhook-* flags.</p></td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file is supposed to be generated ... maybe nothing regenerated it after 1.31?

@netlify Netlify
Copy link

netlify bot commented Oct 22, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 7d8b07e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67187bef0c37230008ac5bde
😎 Deploy Preview https://deploy-preview-48487--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ritazh ritazh force-pushed the kep_3221_ga branch 2 times, most recently from b9f6fad to fa97189 Compare October 22, 2024 05:09
@Shubham82
Copy link
Contributor

/retitle KEP-3221: remove mentions of beta and featuregate, and change order of cmd line

@k8s-ci-robot k8s-ci-robot changed the title KEP-3221: remove mentions of beta and featuregate, and change order o… KEP-3221: remove mentions of beta and featuregate, and change order of cmd line Oct 22, 2024
@Shubham82
Copy link
Contributor

Thanks @ritazh
the changes look good to me.
Preview: https://deploy-preview-48487--kubernetes-io-main-staging.netlify.app/docs/reference/access-authn-authz/authorization/#choice-of-authz-config

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6ff71af38360631b72f66b2a90d380b6e2a0e4f2

@liggitt
Copy link
Member

liggitt commented Oct 22, 2024

lgtm for technical content

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2024
@tengqm
Copy link
Contributor

tengqm commented Oct 23, 2024

Docs lgtm.
One more thing. Why are we targeting dev-1.32 rather than main?
Anything new/special in v1.32? Is there are link to the upstream source code change that is related to this change?

@liggitt
Copy link
Member

liggitt commented Oct 23, 2024

One more thing. Why are we targeting dev-1.32 rather than main?
Anything new/special in v1.32? Is there are link to the upstream source code change that is related to this change?

1.32 is when the structured config is getting promoted to GA

xref kubernetes/kubernetes#128172 #48424

@ritazh
Copy link
Member Author

ritazh commented Oct 25, 2024

@Shubham82 @tengqm @sftim good to merge?

@Shubham82
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 37a58ff7f660fddba2d82ac5f43ef53f9eed95ad

@ritazh
Copy link
Member Author

ritazh commented Nov 19, 2024 •
edited
Loading

@Shubham82 @tengqm @sftim good to merge?

bump :) still missing approval

@Shubham82
Copy link
Contributor

cc @reylejano, need your approval to merge this PR.
PTAL!

Thanks!

@tengqm
Copy link
Contributor

tengqm commented Nov 19, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit d8dbc91 into kubernetes:dev-1.32 Nov 19, 2024
6 checks passed
@ritazh ritazh deleted the kep_3221_ga branch November 19, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@tengqm tengqm tengqm left review comments

@liggitt liggitt liggitt left review comments

@palnabarun palnabarun Awaiting requested review from palnabarun

@Shubham82 Shubham82 Awaiting requested review from Shubham82

Assignees

@Shubham82 Shubham82

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Auth
Archived in project
Milestone
1.32
Development

Successfully merging this pull request may close these issues.
6 participants
@ritazh @Shubham82 @k8s-ci-robot @liggitt @tengqm @sftim