Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bn] Delete Localization READMEs section in localized README #48352

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Okabe-Junya
Copy link
Member

@Okabe-Junya Okabe-Junya commented Oct 15, 2024

Description

ref. #47763 (comment)

  • Delete Localization READMEs section in localized README
    • Now, these links don't work well

/kind cleanup

Issue

Closes: #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rajibmitra for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/localization General issues or PRs related to localization label Oct 15, 2024
@k8s-ci-robot k8s-ci-robot added language/bn Issues or PRs related to Bengali language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 15, 2024
@Okabe-Junya
Copy link
Member Author

/assign @asem-hamid
for approval

@Okabe-Junya
Copy link
Member Author

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 15, 2024
Copy link

netlify bot commented Oct 15, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 73f8188
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/670e840183ac1c0008248324
😎 Deploy Preview https://deploy-preview-48352--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asem-hamid
Copy link
Contributor

@Okabe-Junya Thanks for these changes. This was one of my first questions when I started contributing: 'Why do I need approval from leads to make changes in bn?' . Thanks for fixing the process.

@asem-hamid
Copy link
Contributor

But why are we removing the links instead of updating their path in local files?

@Okabe-Junya
Copy link
Member Author

@Okabe-Junya Thanks for these changes. This was one of my first questions when I started contributing: 'Why do I need approval from leads to make changes in bn?' . Thanks for fixing the process.

Thank you for your comment :)

But why are we removing the links instead of updating their path in local files?

In #47763, we transitioned the ownership of localized READMEs from TL (website-admins) to each l10n team.
At that time, we moved the localized READMEs from the root of the tree to content/xx.

These paths should be specified based on the English version — all l10n in k/website is based on the English content as the source for translations.
There is little need to link between other languages (especially in the README) — and currently, it doesn’t work, so removed this section

@asem-hamid
Copy link
Contributor

If you allow me i can help on that

@asem-hamid
Copy link
Contributor

asem-hamid commented Oct 15, 2024

Code :

## Localization READMEs

| Language                      | Language                         |
| ----------------------------- | -------------------------------- |
| [Bengali](../bn/README.md)    | [Japanese](../ja/README.md)      |
| [Chinese](../zh-cn/README.md) | [Korean](../ko/README.md)        |
| [English](../../README.md)    | [Polish](../pl/README.md)        |
| [French](../fr/README.md)     | [Portuguese](../pt-br/README.md) |
| [German](../de/README.md)     | [Russian](../ru/README.md)       |
| [Hindi](../hi/README.md)      | [Spanish](../es/README.md)       |
| [Indonesian](../id/README.md) | [Ukrainian](../uk/README.md)     |
| [Italian](../it/README.md)    | [Vietnamese](../vi/README.md)    |

preview ( from my fork ): https://github.com/asem-hamid/website/blob/link-test/content/bn/README.md#localization-readmes

I cover every language here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/bn Issues or PRs related to Bengali language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants