Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy <head> for pages #48350

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Tidy <head> for pages #48350

wants to merge 1 commit into from
+26 −11

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Oct 15, 2024

  • Remove duplicated Twitter and Open Graph metadata
  • Render the Open Graph image through Hugo Pipes
  • Move the theme color to the head-end hook

Here's a preview

Helps with issue #41171

/area web-development

@sftim
Tidy <head> for pages
e776fce 
- Remove duplicated Twitter and Open Graph metadata
- Render the Open Graph image through Hugo Pipes
- Move the theme color to the head-end hook
@k8s-ci-robot k8s-ci-robot added the area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes label Oct 15, 2024
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Oct 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from sftim. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 15, 2024
sftim
sftim commented Oct 15, 2024
View reviewed changes
layouts/partials/head.html
@@ -52,27 +49,44 @@
{{ end }}
}
</script>
<meta name="theme-color" content="#326ce5">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to layouts/partials/hooks/head-end.html

sftim
sftim commented Oct 15, 2024
View reviewed changes
layouts/partials/head.html
Comment on lines -25 to -27
{{- template "_internal/opengraph.html" . -}}
{{- template "_internal/schema.html" . -}}
{{- template "_internal/twitter_cards.html" . -}}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing these internal template calls as we are customizing them later in the same layout file.

@netlify Netlify
Copy link

netlify bot commented Oct 15, 2024

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit e776fce
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/670e572a06548900076c59bf
😎 Deploy Preview https://deploy-preview-48350--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salaxander salaxander Awaiting requested review from salaxander

@tengqm tengqm Awaiting requested review from tengqm

Assignees
No one assigned
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sftim @k8s-ci-robot