Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor KubeWeekly signup form #48258

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor KubeWeekly signup form #48258

wants to merge 1 commit into from
+49 −29

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Oct 8, 2024 •
edited
Loading

Turn it into a shortcode [preview]

/area web-development

I have done limited testing. If you want to approve this but are concerned about testing it, hold the PR before you approve. I will then unhold when I have time to test the live site post-merge.

Intended to help with issue #41171

@k8s-ci-robot k8s-ci-robot added area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from sftim. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 8, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 8, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 283abc5
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67642b4b64183100087997b4
😎 Deploy Preview https://deploy-preview-48258--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor Author

sftim commented Oct 8, 2024

/retitle Refactor KubeWeekly signup form

@k8s-ci-robot k8s-ci-robot changed the title Refactory KubeWeekly signup form Refactor KubeWeekly signup form Oct 8, 2024
@sftim sftim force-pushed the 20241008_redo_kubeweekly branch from 4e49eb5 to 5a868dc Compare October 8, 2024 23:12
@sftim sftim force-pushed the 20241008_redo_kubeweekly branch from 5a868dc to 0912de7 Compare October 19, 2024 15:39
@sftim sftim force-pushed the 20241008_redo_kubeweekly branch from 0912de7 to 588b1f0 Compare December 2, 2024 13:14
@sftim sftim force-pushed the 20241008_redo_kubeweekly branch from 588b1f0 to 7f4c165 Compare December 12, 2024 10:05
shurup
shurup reviewed Dec 17, 2024
View reviewed changes
assets/scss/_custom.scss Outdated Show resolved Hide resolved
@shurup
Copy link
Member

shurup commented Dec 17, 2024

My two cents:

  1. Making the "Interested in receiving …" title blue is a bit misleading since all other blue phrases on this page are links (and this one is not).
  2. I'd also end the "Sign up for KubeWeekly" sentence with an exclamation mark (it's an actual call to action, after all).

@sftim sftim force-pushed the 20241008_redo_kubeweekly branch from 04b7c75 to 7a8ab14 Compare December 17, 2024 09:46
@sftim
Copy link
Contributor Author

sftim commented Dec 17, 2024

I'd also end the "Sign up for KubeWeekly" sentence with an exclamation mark (it's an actual call to action, after all).

Let's save that for a separate PR (I also don't want to make that change).

@sftim sftim force-pushed the 20241008_redo_kubeweekly branch from 7a8ab14 to c045e1e Compare December 17, 2024 09:48
@SayakMukhopadhyay
Copy link
Contributor

SayakMukhopadhyay commented Dec 19, 2024 •
edited
Loading

There are a couple of things I want to bring to your attention.

First, the location of the CNCF banner has changed wrt the newsletter location. Is that intended? Also, the text in the newsletter box is less vertically centred than before? Should we try to centre it a bit more?

On the left is the live and on the right is the PR
image

The second one I will review inline.

@sftim
Copy link
Contributor Author

sftim commented Dec 19, 2024

First, the location of the CNCF banner has changed wrt the newsletter location. Is that intended?

Yes, that was intended.

SayakMukhopadhyay
SayakMukhopadhyay reviewed Dec 19, 2024
View reviewed changes
assets/scss/_custom.scss
@@ -96,6 +96,25 @@ body.td-home main[role="main"] > section:first-of-type .content p:first-child {
}
}

.section-feature#kubeweekly {

.kubeweekly-signup {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do > .kubeweekly-inner { h5 to style the h5 block instead of assigning a CSS class.

assets/scss/_custom.scss Outdated Show resolved Hide resolved
@sftim
Copy link
Contributor Author

sftim commented Dec 19, 2024

Also, the text in the newsletter box is less vertically centred than before? Should we try to centre it a bit more?

I think that's a good fit for a follow up PR. Bear in mind the very long lead time on reviews (this is from October 2024); anything that holds up #41171 and isn't essential to that should wait - at least that is my opinion.

@sftim
Copy link
Contributor Author

sftim commented Dec 19, 2024

Basically, if this isn't so bad that we can't merge it: let's merge it, and iterate.

@SayakMukhopadhyay
Copy link
Contributor

Also, the text in the newsletter box is less vertically centred than before? Should we try to centre it a bit more?

I think that's a good fit for a follow up PR. Bear in mind the very long lead time on reviews (this is from October 2024); anything that holds up #41171 and isn't essential to that should wait - at least that is my opinion.

It seems like changing the padding from bottom to top is enough to vertically centre it. Since the padding is part of new code, it should be ok to do it in this PR right?

@sftim
Copy link
Contributor Author

sftim commented Dec 19, 2024

I'll make the change, but: the longer the PR has been open, the more reluctant reviewers should be to call out nits.

@sftim @shurup @SayakMukhopadhyay
Refactor KubeWeekly signup form
283abc5 
Turn it into a shortcode.

Co-authored-by: Dmitry Shurupov <[email protected]>
Co-authored-by: Sayak Mukhopadhyay <[email protected]>
@sftim sftim force-pushed the 20241008_redo_kubeweekly branch from fec1c90 to 283abc5 Compare December 19, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SayakMukhopadhyay SayakMukhopadhyay SayakMukhopadhyay left review comments

@shurup shurup shurup left review comments

@drewhagen drewhagen Awaiting requested review from drewhagen

@tengqm tengqm Awaiting requested review from tengqm

Assignees
No one assigned
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sftim @k8s-ci-robot @shurup @SayakMukhopadhyay