Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Approval permission for 1.32 Release #48158

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Approval permission for 1.32 Release #48158

merged 2 commits into from
Oct 7, 2024

Conversation

chanieljdan
Copy link
Contributor

@chanieljdan chanieljdan commented Oct 1, 2024 •
edited
Loading

As the 1.32 Release Docs lead, I would like to add myself to the approver list for the dev-1.32 branch

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 1, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 1, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 1, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 12393c2
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67040fdd34385a0008cf1379
😎 Deploy Preview https://deploy-preview-48158--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tengqm
Copy link
Contributor

tengqm commented Oct 1, 2024

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2024
@sftim
Copy link
Contributor

sftim commented Oct 1, 2024

As the 1.32 Release Docs lead, I would like to add myself to the approver list for the dev-1.21 branch

Guessing you meant dev-1.32 there!

sftim
sftim reviewed Oct 1, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems to target the wrong branch.

/approve cancel
I assume that you meant to send this PR in against dev-1.32

@tengqm
Copy link
Contributor

tengqm commented Oct 2, 2024 •
edited
Loading

No. I don't think this should target dev-1.32. The change to OWNER_ALIAS is temporary, but the whole site wide. I could be wrong though.
/approve
again.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tengqm
Copy link
Contributor

tengqm commented Oct 2, 2024

xref: #47390
xref: #44709

@chanieljdan
Copy link
Contributor Author

xref: #47390 xref: #44709

Yeah these were the examples I followed, as well as #26114. Let me know if it is indeed the wrong branch though, I can update it!

@chanieljdan
Copy link
Contributor Author

Hey @sftim I followed the examples above and targeted the PR to the main branch, let me know if it is indeed the wrong branch, but if not, could I get your lgtm?

@sftim
Copy link
Contributor

sftim commented Oct 6, 2024

could I get your lgtm

I still think this is the wrong approach. I don't object to another person adding LGTM if other people are confident I'm wrong.

drewhagen
drewhagen reviewed Oct 7, 2024
View reviewed changes
OWNERS_ALIASES Outdated
@@ -66,6 +66,7 @@ aliases:
- tengqm
- Princesso # RT 1.31 Docs Lead
- drewhagen # RT 1.31 temp acting Docs lead
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Princess and I were supposed to be removed. Could you do me a favor and remove us as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@chanieljdan
remove past docs leads
12393c2 
drew and princess were docs leads for past release cycles, their membership in owners is not required anymore
@drewhagen
Copy link
Member

This is correct. The PR needs to target the main branch as it has every release.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 40913fe5dfba099a5e8b9c08f55582584df085eb

@k8s-ci-robot k8s-ci-robot merged commit 9a27845 into kubernetes:main Oct 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@drewhagen drewhagen drewhagen left review comments

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

Assignees

@drewhagen drewhagen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chanieljdan @tengqm @sftim @k8s-ci-robot @drewhagen