Restyle glossary page #47484
Restyle glossary page #47484
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
sig/docs
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Match the theme more closely, and use SCSS to define the styling. Also change the permalink hover behavior to be pure CSS.
sftim
force-pushed
the
20240514_restyle_glossary
branch
from
0249aca to
8214a5f
Compare
| // Shows permalink when term name is hovered over | ||
| $(".term-name").each(function() { | ||
| var permalink = $($(this).parent().find(".permalink")[0]); | ||
| $(this).mouseenter(function(){ | ||
| permalink.removeClass("hide"); | ||
| }).mouseleave(function(){ | ||
| permalink.addClass("hide"); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
This part is now done with pure CSS
| ul.glossary-terms > li:has(.term-anchor:target) { | ||
| border-left: 0.3em solid $blue; | ||
| background: rgba(#999999, 0.2); | ||
| } |
There was a problem hiding this comment.
This highlights the current glossary entry, if there is one selected via a fragment identifier.
There was a problem hiding this comment.
The build preview (here) shows the Glossary page working as intended (along with some visible styling changes). Nice work here on making strides towards aligning with Docsy!
/lgtm
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 980ff9aa8f082f0810eaf63a3e4358a272ebba5d
|
|
/approve Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: katcosgrove The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Match the theme more closely, and use SCSS to define the styling.
/area web-development
Helps towards #41171
Before | Afterwards