Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenting audit annotation to transforming response object #47450

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Ritikaa96
Copy link
Contributor

Documenting audit annotations which records latency in transforming response object

  • apiserver.latency.k8s.io/transform-response-object
  • apiserver.latency.k8s.io/serialize-response-object
  • apiserver.latency.k8s.io/response-write

Partially Fixes: #29479

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Aug 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign katcosgrove for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 12, 2024
@Ritikaa96
Copy link
Contributor Author

/sig docs
/sig auth
/kind feature

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/auth Categorizes an issue or PR as relevant to SIG Auth. kind/feature Categorizes issue or PR as related to a new feature. labels Aug 12, 2024
@k8s-ci-robot
Copy link
Contributor

@Ritikaa96: The label(s) sig/ cannot be applied, because the repository doesn't have them.

In response to this:

/sig docs
/sig auth
/kind feature

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Ritikaa96
Copy link
Contributor Author

Reference taken from audit.go and webhook.go

Copy link

netlify bot commented Aug 12, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 3bcd4e4
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66b999f19d25510008a637ae
😎 Deploy Preview https://deploy-preview-47450--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aramase
Copy link
Member

aramase commented Aug 12, 2024

/sig api-machinery
/remove-sig auth

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed sig/auth Categorizes an issue or PR as relevant to SIG Auth. labels Aug 12, 2024
@Ritikaa96
Copy link
Contributor Author

Any update on this?

@Ritikaa96
Copy link
Contributor Author

Waiting for the reviews for this one. Is there any changes i need to make?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. language/en Issues or PRs related to English language sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Status: !SIG Auth
Development

Successfully merging this pull request may close these issues.

Document well-known audit annotations
3 participants