Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature gate WatchFromStorageWithoutResourceVersion for v1.30 #47260

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Jul 24, 2024

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 24, 2024
Copy link

netlify bot commented Jul 24, 2024

Pull request preview available for checking

Name Link
🔨 Latest commit adfb685
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66a0e7a1f09ed60008af7b08
😎 Deploy Preview https://deploy-preview-47260--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot
Copy link
Contributor

@Shubham82: The label(s) sig/spi-machinery cannot be applied, because the repository doesn't have them.

In response to this:

FYI: Here is the corresponding upstream PR: kubernetes/kubernetes#123935

/sig spi-machinery

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Shubham82
Copy link
Contributor

FYI: Here is the corresponding upstream PR: kubernetes/kubernetes#123935

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jul 25, 2024
@Shubham82
Copy link
Contributor

Shubham82 commented Jul 25, 2024

Thanks @tengqm for the PR.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d89f84a4328a174e622d53e16da4abbe5c30e6da

@salaxander
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: salaxander

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8fd9de4 into kubernetes:main Jul 25, 2024
6 checks passed
@tengqm tengqm deleted the fg-wfswrv branch July 26, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants