Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bn] Delete rewrite-target annotation in ingress example #47211

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

Arhell
Copy link
Member

@Arhell Arhell commented Jul 19, 2024

@k8s-ci-robot k8s-ci-robot requested a review from asem-hamid July 19, 2024 21:34
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 19, 2024
@k8s-ci-robot k8s-ci-robot requested a review from sajibAdhi July 19, 2024 21:34
@k8s-ci-robot k8s-ci-robot added area/localization General issues or PRs related to localization language/bn Issues or PRs related to Bengali language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 19, 2024
Copy link

netlify bot commented Jul 19, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 239ece3
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/669adbf576697600085d5740
😎 Deploy Preview https://deploy-preview-47211--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed change looks in sync with 'en' PR https://github.com/kubernetes/website/pull/46761/files

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 03e8c0ef4b1a6f4c4f72f680f0537c3c71e0f6d4

@dipesh-rawat dipesh-rawat removed their assignment Jul 22, 2024
Copy link
Contributor

@sajibAdhi sajibAdhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asem-hamid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit c149f75 into kubernetes:main Jul 25, 2024
6 checks passed
@Arhell Arhell deleted the bn-del branch July 25, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/bn Issues or PRs related to Bengali language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants