Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blog for PersistentVolumeLastPhaseTransitionTime feature GA in v1.31 #47206

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Add blog for PersistentVolumeLastPhaseTransitionTime feature GA in v1.31 #47206

merged 1 commit into from
Aug 13, 2024

Conversation

RomanBednar
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 19, 2024
@RomanBednar
Copy link
Contributor Author

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/blog Issues or PRs related to the Kubernetes Blog subproject labels Jul 19, 2024
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jul 19, 2024
@RomanBednar
Copy link
Contributor Author

/hold

Need to set correct date.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 19, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 29383f3
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66b4872e5d76cd0008bcd30a
😎 Deploy Preview https://deploy-preview-47206--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RomanBednar RomanBednar force-pushed the pv-last-phase-transition-time-ga-blog branch from 863f8c2 to 19231af Compare July 19, 2024 13:03
@mbianchidev
Copy link
Member

Hey @RomanBednar , it's Matteo from the 1.31 Release comms team.
I'm reaching out with a reminder that the blog ready for review deadline is July 26, 2024.

Please let me know how we can help with content, review or anything else 😄

@sftim
Copy link
Contributor

sftim commented Jul 21, 2024

@mbianchidev you can:

  • let the author know if they can have an exception (this PR missed a deadline)
  • if so, assign a tentative publication date

@mbianchidev
Copy link
Member

Thanks @sftim !

So @RomanBednar we are ok with stretching the blog deadline for this one.
I'll mark it as ready for review and try to come up with a publication date ASAP.

@mbianchidev
Copy link
Member

Thanks @sftim !

So @RomanBednar we are ok with stretching the blog deadline for this one. I'll mark it as ready for review and try to come up with a publication date ASAP.

Currently the publication date is set to the 13th of August!

@RomanBednar RomanBednar force-pushed the pv-last-phase-transition-time-ga-blog branch from 19231af to ff218f1 Compare July 25, 2024 10:20
@RomanBednar
Copy link
Contributor Author

@mbianchidev Thank you, I've updated the date.

@RomanBednar
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2024
@sftim
Copy link
Contributor

sftim commented Jul 26, 2024

/hold

OK to unhold once Kubernetes v1.31 has been released.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 26, 2024
@RomanBednar RomanBednar force-pushed the pv-last-phase-transition-time-ga-blog branch from ff218f1 to 920a114 Compare July 29, 2024 08:05
@tengqm
Copy link
Contributor

tengqm commented Jul 29, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 50f6b4167050b29f43e430886ad0970cb22c607c

sftim
sftim reviewed Jul 29, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tweaks I suggest

content/en/blog/_posts/2024-08-13-pv-last-phase-transition-time-ga.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-08-13-pv-last-phase-transition-time-ga.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-08-13-pv-last-phase-transition-time-ga.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2024
@k8s-ci-robot k8s-ci-robot requested a review from tengqm July 29, 2024 12:41
@RomanBednar RomanBednar force-pushed the pv-last-phase-transition-time-ga-blog branch from 53514c6 to 0eb4f10 Compare July 29, 2024 12:44
@RomanBednar
Copy link
Contributor Author

@sftim @tengqm Thank you for reviews, I've applied the suggestions and squashed everything.

@mbianchidev
Copy link
Member

hey @natalisucks, this one has been lgtm-ed before, now every comment should be addressed, can you help with labels? 👀

@sftim
Copy link
Contributor

sftim commented Aug 7, 2024

Thanks @sftim !
So @RomanBednar we are ok with stretching the blog deadline for this one. I'll mark it as ready for review and try to come up with a publication date ASAP.

Currently the publication date is set to the 13th of August!

That is after the date set for the release announcement. Seems wrong.

@a-mccarthy
Copy link
Contributor

Thanks @sftim !
So @RomanBednar we are ok with stretching the blog deadline for this one. I'll mark it as ready for review and try to come up with a publication date ASAP.

Currently the publication date is set to the 13th of August!

That is after the date set for the release announcement. Seems wrong.

@RomanBednar the publication date should be August 14th.

cc: @mbianchidev

@sftim
Copy link
Contributor

sftim commented Aug 7, 2024

Let's pick a specific publication time; there are several articles due to go out on release day, and it's important that the earliest one out of the set is the release announcement.

@mbianchidev
Copy link
Member

Thanks @sftim !
So @RomanBednar we are ok with stretching the blog deadline for this one. I'll mark it as ready for review and try to come up with a publication date ASAP.

Currently the publication date is set to the 13th of August!

That is after the date set for the release announcement. Seems wrong.

@RomanBednar the publication date should be August 14th.

cc: @mbianchidev

I adjusted the board to reflect the change, it was set to the wrong date.
About setting a time let's pick one for the release blog and the ones going out the day of the release, for any other blog time is probably not-so-sensitive.

@RomanBednar RomanBednar force-pushed the pv-last-phase-transition-time-ga-blog branch from 0eb4f10 to 29383f3 Compare August 8, 2024 08:51
@RomanBednar
Copy link
Contributor Author

Thanks for the heads up, I've set the date to 2024-08-14.

cc @a-mccarthy @sftim @mbianchidev

@natalisucks
Copy link
Contributor

Given this Slack thread re: specific time for the blog and the clarified items going out on release day, this looks good to me without a specific time
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natalisucks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2024
@sftim
Copy link
Contributor

sftim commented Aug 8, 2024

/lgtm

🛑 Do not unhold or merge before Kubernetes v1.31 is released 🛑

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5f985316333add8a8c1dec08a4987c960eb7a6c2

@dipesh-rawat
Copy link
Member

/unhold

Kubernetes v1.31 has been released.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit 7b7b184 into kubernetes:main Aug 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@Gauravpadam Gauravpadam Awaiting requested review from Gauravpadam

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@tengqm tengqm Awaiting requested review from tengqm

Assignees

@tengqm tengqm

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Docs Blog Project Board
Status: Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@RomanBednar @mbianchidev @sftim @tengqm @k8s-ci-robot @a-mccarthy @natalisucks @dipesh-rawat