Device plugin failures: KEP docs #47029

SergeyKanzhelev · 2024-06-29T06:51:24Z

/sig node

netlify · 2024-06-29T06:54:00Z

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`780f166`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/667faeee41ce650007f6b4f1
😎 Deploy Preview	https://deploy-preview-47029--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2024-06-29T06:56:56Z

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`bb5d11b`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66a921eae8ded0000801d0a3
😎 Deploy Preview	https://deploy-preview-47029--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Princesso · 2024-07-09T08:35:18Z

Hello @SergeyKanzhelev 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday July 16th 2024 18:00 PST. Thank you!

Princesso · 2024-07-15T07:42:37Z

Hi @SergeyKanzhelev, a gentle reminder that tomorrow is the deadline for having your Docs PR ready for review. Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before tomorrow, Tuesday, July 16th, 2024 18:00 PST.

hacktivist123 · 2024-07-23T12:52:10Z

Hello @SergeyKanzhelev 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Tuesday, July 30th 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. The status of this enhancement is marked as at risk for docs freeze.

Thank you!

hacktivist123 · 2024-07-25T09:41:02Z

/sig node

katcosgrove · 2024-07-25T18:21:26Z

Hi, @SergeyKanzhelev. This PR is very, very far beyond its deadlines. Release Docs has tried to reach you repeatedly. The Docs Ready for Review deadline was last week, and the Docs Freeze is in 5 days. If you do not have documentation in this PR today and begin reviews, we will be forced to consider pulling this enhancement from the release. Please acknowledge.

@kubernetes/sig-node-leads

netlify · 2024-07-25T19:30:59Z

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name	Link
🔨 Latest commit	`bb5d11b`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/66a921eae854fb0008f53981

content/en/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins.md

kannon92 · 2024-07-25T19:35:33Z

/cc @ffromani

TBH I don't have as much understanding about how scheduling works with device plugins. Maybe @ffromani can also review?

Otherwise, it looks good to me.

ffromani

/lgtm

from sig-node. Content looks correct and reflects KEP and implementation, minor nonblocking comment inside

content/en/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins.md

content/en/docs/reference/command-line-tools-reference/feature-gates/resource-health-status.md

Princesso · 2024-07-29T12:02:11Z

Hello @SergeyKanzhelev,

v1.31 Doc Lead here. This PR has been marked as at risk for Doc Freeze.

The Doc Reviewers have given feedback on it, however, an update is yet to be made on it, based on feedback.

Please note that the Doc freeze deadline is tomorrow, and if the PR is not merged by tomorrow, you will need to file an exception or this enhancement will be removed from this release. Thank you!

mrunalp

/lgtm

k8s-ci-robot · 2024-07-29T16:41:57Z

LGTM label has been added.

Git tree hash: 18451a0b4ae73242e5b211e8f16bc700cac8bc84

ffromani · 2024-07-29T17:51:06Z

LGTM content-wise from sig-node perspective (I see @mrunalp already added the tag)

sftim

Thanks

Docs feedback; this is close to being OK for alpha, but I do recommend some edits.

content/en/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins.md

sftim · 2024-07-30T10:34:20Z

content/en/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins.md

+This status can be used to understand whether pod failure or misbehavior was associated
+with the device failure.


I'm guessing here:

Suggested change

This status can be used to understand whether pod failure or misbehavior was associated

with the device failure.

For a failed Pod, or or where you suspect a fault, you can use this status to understand whether

the Pod behavior may be associated with device failure. For example, if an accelerator is reporting

an over-temperature event, the `allocatedResourcesStatus` field may be able to report this.

Does that example look correct?

(would like confirmation I guessed right)

The device plugin API doesn't have provision to report unhealthy reason. The device will thus report to the kubelet just healthy/unhealthy. The current user-facing API (in the pod object) also report just healthy/unhealty. So the example is realistic, but in the pod status the user won't actually find "unhealthy because overheating" in 1.31, but just "unhealthy". @SergeyKanzhelev to keep me honest here.

OK cool. Polishing this up post-merge is fine.

How do we feel about a separate controller annotating the Pod with more detail vs. reporting an Event vs. neither of those?

@sftim IMO this is great input for the next stages of this work!

content/en/docs/reference/command-line-tools-reference/feature-gates/resource-health-status.md

Princesso · 2024-07-30T12:53:15Z

Hello @SergeyKanzhelev

v1.31 Doc Lead here. This PR is still at risk for Doc Freeze because it is yet to be merged.
Please implement the changes required by the reviewers to have another round of reviews.

Kindly note that if the PR is not merged by 18:00 PDT today, you will need to file an exception for the associated enhancement to be a part of this milestone. Thank you!

katcosgrove

Quick pass for grammar

content/en/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins.md

ffromani

/lgtm

contentwise from sig-node perspective

k8s-ci-robot · 2024-07-30T16:40:48Z

LGTM label has been added.

Git tree hash: 84c0677cdd1dc57d57c92fe8714a9f85824d779c

sftim · 2024-07-30T16:44:09Z

/label tide/merge-method-squash

If you squash this to 1 commit keeping the same merge base and final tree, Prow keeps the LGTM too. And it's tidier in the commit history.

sftim

/hold
/approve

I recommend a local squash, then forced push (git push --force-with-lease), then unhold to merge the now squashed commits.

k8s-ci-robot · 2024-07-30T16:46:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/docs/OWNERS~~ [sftim]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sftim · 2024-07-30T16:46:10Z

OK to unhold if this has been squashed, or if we decide to skip that because of deadlines.

SergeyKanzhelev · 2024-07-30T17:25:22Z

/unhold

k8s-ci-robot requested review from lavalamp and mengjiao-liu June 29, 2024 06:51

k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jun 29, 2024

SergeyKanzhelev changed the base branch from main to dev-1.31 June 29, 2024 06:52

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 29, 2024

SergeyKanzhelev mentioned this pull request Jun 29, 2024

Add Resource Health Status to the Pod Status for Device Plugin and DRA kubernetes/enhancements#4680

Open

10 tasks

SergeyKanzhelev force-pushed the device-plugin-failures branch from 6e0ba11 to 6b542f0 Compare July 25, 2024 19:30

k8s-ci-robot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 25, 2024

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 25, 2024

SergeyKanzhelev changed the title ~~[WIP] Device plugin failures: KEP docs~~ Device plugin failures: KEP docs Jul 25, 2024

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 25, 2024

kannon92 reviewed Jul 25, 2024

View reviewed changes

content/en/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins.md Outdated Show resolved Hide resolved

kannon92 reviewed Jul 25, 2024

View reviewed changes

content/en/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins.md Outdated Show resolved Hide resolved

k8s-ci-robot requested a review from ffromani July 25, 2024 19:35

ffromani reviewed Jul 26, 2024

View reviewed changes

content/en/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins.md Outdated Show resolved Hide resolved

dipesh-rawat reviewed Jul 26, 2024

View reviewed changes

content/en/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins.md Outdated Show resolved Hide resolved

content/en/docs/reference/command-line-tools-reference/feature-gates/resource-health-status.md Outdated Show resolved Hide resolved

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2024

k8s-ci-robot requested a review from ffromani July 29, 2024 16:38

mrunalp approved these changes Jul 29, 2024

View reviewed changes

k8s-ci-robot assigned mrunalp Jul 29, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2024

sftim reviewed Jul 30, 2024

View reviewed changes

katcosgrove reviewed Jul 30, 2024

View reviewed changes

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2024

k8s-ci-robot requested a review from mrunalp July 30, 2024 16:36

ffromani reviewed Jul 30, 2024

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2024

k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 30, 2024

sftim reviewed Jul 30, 2024

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 30, 2024

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2024

device plugin failures

bb5d11b

SergeyKanzhelev force-pushed the device-plugin-failures branch from d8d2d87 to bb5d11b Compare July 30, 2024 17:24

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 30, 2024

k8s-ci-robot merged commit cdd0f61 into kubernetes:dev-1.31 Jul 30, 2024
6 checks passed

k8s-ci-robot added this to the 1.31 milestone Jul 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Device plugin failures: KEP docs #47029

Device plugin failures: KEP docs #47029

SergeyKanzhelev commented Jun 29, 2024

netlify bot commented Jun 29, 2024

netlify bot commented Jun 29, 2024 •

edited

Loading

Princesso commented Jul 9, 2024

Princesso commented Jul 15, 2024

hacktivist123 commented Jul 23, 2024 •

edited

Loading

hacktivist123 commented Jul 25, 2024

katcosgrove commented Jul 25, 2024

netlify bot commented Jul 25, 2024 •

edited

Loading

kannon92 commented Jul 25, 2024

ffromani left a comment

Princesso commented Jul 29, 2024

mrunalp left a comment

k8s-ci-robot commented Jul 29, 2024

ffromani commented Jul 29, 2024

sftim left a comment

sftim Jul 30, 2024

sftim Jul 30, 2024

sftim Jul 30, 2024

ffromani Jul 30, 2024

sftim Jul 30, 2024

ffromani Jul 30, 2024

Princesso commented Jul 30, 2024 •

edited

Loading

katcosgrove left a comment

ffromani left a comment

k8s-ci-robot commented Jul 30, 2024

sftim commented Jul 30, 2024

sftim left a comment

k8s-ci-robot commented Jul 30, 2024

sftim commented Jul 30, 2024

SergeyKanzhelev commented Jul 30, 2024

		This status can be used to understand whether pod failure or misbehavior was associated
		with the device failure.

-This status can be used to understand whether pod failure or misbehavior was associated
-with the device failure.
+For a failed Pod, or or where you suspect a fault, you can use this status to understand whether
+the Pod behavior may be associated with device failure. For example, if an accelerator is reporting
+an over-temperature event, the `allocatedResourcesStatus` field may be able to report this.

Device plugin failures: KEP docs #47029

Device plugin failures: KEP docs #47029

Conversation

SergeyKanzhelev commented Jun 29, 2024

netlify bot commented Jun 29, 2024

✅ Pull request preview available for checking

netlify bot commented Jun 29, 2024 • edited Loading

✅ Pull request preview available for checking

Princesso commented Jul 9, 2024

Princesso commented Jul 15, 2024

hacktivist123 commented Jul 23, 2024 • edited Loading

hacktivist123 commented Jul 25, 2024

katcosgrove commented Jul 25, 2024

netlify bot commented Jul 25, 2024 • edited Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

kannon92 commented Jul 25, 2024

ffromani left a comment

Choose a reason for hiding this comment

Princesso commented Jul 29, 2024

mrunalp left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jul 29, 2024

ffromani commented Jul 29, 2024

sftim left a comment

Choose a reason for hiding this comment

sftim Jul 30, 2024

Choose a reason for hiding this comment

sftim Jul 30, 2024

Choose a reason for hiding this comment

sftim Jul 30, 2024

Choose a reason for hiding this comment

ffromani Jul 30, 2024

Choose a reason for hiding this comment

sftim Jul 30, 2024

Choose a reason for hiding this comment

ffromani Jul 30, 2024

Choose a reason for hiding this comment

Princesso commented Jul 30, 2024 • edited Loading

katcosgrove left a comment

Choose a reason for hiding this comment

ffromani left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jul 30, 2024

sftim commented Jul 30, 2024

sftim left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jul 30, 2024

sftim commented Jul 30, 2024

SergeyKanzhelev commented Jul 30, 2024

netlify bot commented Jun 29, 2024 •

edited

Loading

hacktivist123 commented Jul 23, 2024 •

edited

Loading

netlify bot commented Jul 25, 2024 •

edited

Loading

Princesso commented Jul 30, 2024 •

edited

Loading