Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ja] Translate content/en/docs/concepts/scheduling-eviction/pod-scheduling-readiness.md into Japanese #47011

Merged
merged 7 commits into from
Aug 20, 2024
Merged

[ja] Translate content/en/docs/concepts/scheduling-eviction/pod-scheduling-readiness.md into Japanese #47011

merged 7 commits into from
Aug 20, 2024

Conversation

EigoOda
Copy link
Contributor

@EigoOda EigoOda commented Jun 28, 2024

Closes: #44971

@k8s-ci-robot k8s-ci-robot requested a review from atoato88 June 28, 2024 05:34
@EigoOda EigoOda marked this pull request as draft June 28, 2024 05:34
@k8s-ci-robot k8s-ci-robot added the area/localization General issues or PRs related to localization label Jun 28, 2024
@k8s-ci-robot k8s-ci-robot requested a review from bells17 June 28, 2024 05:34
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 28, 2024
@EigoOda EigoOda changed the title [jp] Translate content/en/docs/concepts/scheduling-eviction/pod-scheduling-readiness.md into Japanese [ja] Translate content/en/docs/concepts/scheduling-eviction/pod-scheduling-readiness.md into Japanese Jun 28, 2024
@EigoOda
Copy link
Contributor Author

EigoOda commented Jun 28, 2024

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 28, 2024
@Okabe-Junya
Copy link
Member

@EigoOda

こちら進捗いかがでしょうか。。ログ見ると、以下のようなエラーが発生しているので、/content/en/examples/pods/pod-with-scheduling-gates.yaml や ./content/en/examples/pods/pod-without-scheduling-gates.yaml の "en" を "ja" に置き換えた箇所にコピーしてもらえたら（解消できると）思います。

10:51:06 PM: ERROR [ja] "pod-with-scheduling-gates.yaml" not found in "docs/concepts/scheduling-eviction/pods"
10:51:06 PM: ERROR [ja] "pod-without-scheduling-gates.yaml" not found in "docs/concepts/scheduling-eviction/pods"

@EigoOda
Copy link
Contributor Author

EigoOda commented Jul 29, 2024

@Okabe-Junya
まだ途中までしか翻訳できてないため、Draft にさせてもらってます🙏
今週中には、Ready になるように対応したいと思います。

@Okabe-Junya
Copy link
Member

ありがとうございます！特に急いでいないので、お時間のあるときでいつでも大丈夫です🙆‍♂️

PRが一定期間staleするとbotによって自動的にcloseされてしまうので、一応メンションさせて頂いた次第です！よろしくお願いします〜！

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 3, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 3, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 3, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit e3bb5de
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66c4505121d8e80008eed2b9
😎 Deploy Preview https://deploy-preview-47011--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@EigoOda
Copy link
Contributor Author

EigoOda commented Aug 3, 2024

/label tide/merge-method-squash

@EigoOda EigoOda marked this pull request as ready for review August 3, 2024 09:46
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 3, 2024
@k8s-ci-robot k8s-ci-robot requested a review from kakts August 3, 2024 09:46
@k8s-ci-robot k8s-ci-robot requested a review from t-inu August 3, 2024 09:46
@Okabe-Junya
Copy link
Member

cc @atoato88 @bells17 (@t-inu @kakts)

どなたかこのPRレビューいただきたいです

@johnnyboystar22 johnnyboystar22 mentioned this pull request Aug 12, 2024
Closed
t-inu
t-inu reviewed Aug 15, 2024
View reviewed changes
content/ja/docs/concepts/scheduling-eviction/pod-scheduling-readiness.md Outdated Show resolved Hide resolved
content/ja/docs/concepts/scheduling-eviction/pod-scheduling-readiness.md Outdated Show resolved Hide resolved
content/ja/docs/concepts/scheduling-eviction/pod-scheduling-readiness.md Outdated Show resolved Hide resolved
content/ja/docs/concepts/scheduling-eviction/pod-scheduling-readiness.md Outdated Show resolved Hide resolved
content/ja/docs/concepts/scheduling-eviction/pod-scheduling-readiness.md Outdated Show resolved Hide resolved
content/ja/docs/concepts/scheduling-eviction/pod-scheduling-readiness.md Outdated Show resolved Hide resolved
content/ja/docs/concepts/scheduling-eviction/pod-scheduling-readiness.md Outdated Show resolved Hide resolved
content/ja/docs/concepts/scheduling-eviction/pod-scheduling-readiness.md Outdated Show resolved Hide resolved
content/ja/docs/concepts/scheduling-eviction/pod-scheduling-readiness.md Outdated Show resolved Hide resolved
@EigoOda
Copy link
Contributor Author

EigoOda commented Aug 20, 2024

@t-inu
レビューありがとうございます！
e3bb5de でまとめて修正させていただきました。

t-inu
t-inu reviewed Aug 20, 2024
View reviewed changes
Copy link
Member

@t-inu t-inu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 20, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6082cf5a27ccddd135bb6b57bb143f350f981a48

Okabe-Junya
Okabe-Junya reviewed Aug 20, 2024
View reviewed changes
Copy link
Member

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます！

/assign
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Okabe-Junya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit 16fbab6 into kubernetes:main Aug 20, 2024
6 checks passed
jimangel pushed a commit to jimangel/website that referenced this pull request Oct 30, 2024
@EigoOda @jimangel
[ja] Translate content/en/docs/concepts/scheduling-eviction/pod-sched…
991d3bf 
…uling-readiness.md into Japanese (kubernetes#47011)

* Translate content/en/docs/concepts/scheduling-eviction/pod-scheduling-readiness.md into Japanese

* Update content

* Update article

* Add content/ja/examples/pods

* Update article

* Update title

* Fix style and translation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Okabe-Junya Okabe-Junya Okabe-Junya left review comments

@t-inu t-inu t-inu left review comments

@atoato88 atoato88 Awaiting requested review from atoato88

@bells17 bells17 Awaiting requested review from bells17

@kakts kakts Awaiting requested review from kakts

Assignees

@t-inu t-inu

@Okabe-Junya Okabe-Junya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ja] Translate content/en/docs/concepts/scheduling-eviction/pod-scheduling-readiness.md into Japanese
4 participants
@EigoOda @Okabe-Junya @k8s-ci-robot @t-inu