Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style unfixed vulnerabilities in bold #46996

Merged

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Jun 27, 2024

For the CVE feed page, use bold for any vulnerability that hasn't been fixed. Preview.

Relies on changes from kubernetes/sig-security#115

For the CVE feed, use bold for any vulnerability that hasn't been fixed.
@k8s-ci-robot k8s-ci-robot requested a review from katcosgrove June 27, 2024 12:28
@k8s-ci-robot k8s-ci-robot added the area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes label Jun 27, 2024
@k8s-ci-robot k8s-ci-robot requested a review from salaxander June 27, 2024 12:28
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 27, 2024
Copy link

netlify bot commented Jun 27, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 3fd2bdb
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/667d5aff87d718000886f548
😎 Deploy Preview https://deploy-preview-46996--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor Author

sftim commented Jun 27, 2024

I tested this locally by changing the CSS selector manually.

Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
(Reviewed the changes and confirmed everything works perfectly by adjusting the CSS class to cve-status-open and cve-status-open using the browser's developer tools.

/lgtm
/approve (Unofficially giving the nod of approval; official approval required from sig-docs-website-owner)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 246ac005bbd70b85b88f677ff0bf5e732fa932bb

@stmcginnis
Copy link
Contributor

/lgtm

@katcosgrove
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: katcosgrove

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit 75df5d4 into kubernetes:main Jun 27, 2024
6 checks passed
@sftim sftim deleted the 20240627_mark_outstanding_vulnerabilities branch June 27, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants