Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update portworxVolume doc #46506

Merged
merged 3 commits into from
Jun 20, 2024
Merged

update portworxVolume doc #46506

merged 3 commits into from
Jun 20, 2024

Conversation

carlory
Copy link
Member

@carlory carlory commented May 23, 2024

@k8s-ci-robot k8s-ci-robot added this to the 1.31 milestone May 23, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 23, 2024
@netlify Netlify
Copy link

netlify bot commented May 23, 2024 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 5aa2532
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6673a82ab1a99900088c51d5

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label May 23, 2024
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label May 23, 2024
@carlory
Copy link
Member Author

carlory commented May 23, 2024

/hold
/cc @lpabon

@k8s-ci-robot k8s-ci-robot requested a review from lpabon May 23, 2024 07:08
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2024
@netlify Netlify
Copy link

netlify bot commented May 23, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 5aa2532
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6673a82aa13aad0008f751bf
😎 Deploy Preview https://deploy-preview-46506--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 24, 2024
@carlory @sftim
update portworxVolume doc
2a36ab9 
Co-authored-by: Tim Bannister <[email protected]>
mengjiao-liu
mengjiao-liu reviewed May 24, 2024
View reviewed changes
Copy link
Member

@mengjiao-liu mengjiao-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b4a78f1709110211649e01574196898f57574dda

@lpabon
Copy link
Contributor

lpabon commented Jun 19, 2024

/approve

Thank you!

@xing-yang
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2024
@xing-yang
Copy link
Contributor

/lgtm

@mengjiao-liu
Copy link
Member

mengjiao-liu commented Jun 20, 2024 •
edited
Loading

The sig-storage tech reviewer has approved.

/assign @divya-mohan0209
for approval

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2024
@tengqm
Copy link
Contributor

tengqm commented Jun 20, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lpabon, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2024
@dipesh-rawat
Copy link
Member

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 20, 2024
dipesh-rawat
dipesh-rawat reviewed Jun 20, 2024
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

(Tech LGTM was applied in #46506 (comment))

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 43b52794b6dee7582b928d41923c5e94534c3f2c

@k8s-ci-robot k8s-ci-robot merged commit 0fc04db into kubernetes:dev-1.31 Jun 20, 2024
6 checks passed
@carlory carlory deleted the px branch June 21, 2024 02:05
@xing-yang xing-yang mentioned this pull request Jun 22, 2024
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@tengqm tengqm tengqm left review comments

@thockin thockin Awaiting requested review from thockin

@xing-yang xing-yang Awaiting requested review from xing-yang

@lpabon lpabon Awaiting requested review from lpabon

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

@mengjiao-liu mengjiao-liu Awaiting requested review from mengjiao-liu

Assignees

@xing-yang xing-yang

@dipesh-rawat dipesh-rawat

@divya-mohan0209 divya-mohan0209

@mengjiao-liu mengjiao-liu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
1.31
Development

Successfully merging this pull request may close these issues.
9 participants
@carlory @k8s-ci-robot @lpabon @xing-yang @mengjiao-liu @tengqm @dipesh-rawat @sftim @divya-mohan0209