Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm: move the RootlessControlPlane FG to deprecated #46464

Merged

Conversation

neolit123
Copy link
Member

The feature was left in alpha for a few releases, since k8s started planning on a broader feature UserNamespacesSupport, which is what kubeadm should integrate with.

UserNamespacesSupport graduated to beta in 1.30.
Once it graduates to GA kubeadm can start using it an remove RootlessControlPlane.

/sig cluster-lifecycle

kubernetes/kubeadm#2473 (comment)
kubernetes/kubernetes#124997

@k8s-ci-robot k8s-ci-robot added this to the 1.31 milestone May 20, 2024
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 20, 2024
@neolit123
Copy link
Member Author

/cc @SataQiu @pacoxu

Copy link

netlify bot commented May 20, 2024

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 7f892d6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/664b5992cbfaa60009a21c34

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 20, 2024
@k8s-ci-robot k8s-ci-robot requested review from pacoxu and SataQiu May 20, 2024 14:09
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label May 20, 2024
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label May 20, 2024
@neolit123
Copy link
Member Author

/kind deprecation

@k8s-ci-robot k8s-ci-robot added the kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. label May 20, 2024
Copy link

netlify bot commented May 20, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 7f892d6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/664b599204e6e40008ec6e32
😎 Deploy Preview https://deploy-preview-46464--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@neolit123
Copy link
Member Author

kubernetes/kubernetes#124997 merged
PTAL for LGTM
@pacoxu @SataQiu

Copy link
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 34f13ef79970da18fcf3de2280d1b5ea6fd91a1c

@pacoxu
Copy link
Member

pacoxu commented May 29, 2024

/lgtm
/assign @tengqm

@tengqm
Copy link
Contributor

tengqm commented May 29, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SataQiu, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit 096a265 into kubernetes:dev-1.31 May 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants