Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graduate PersistentVolumeLastPhaseTransitionTime to GA in v1.31 #46463

Merged
merged 1 commit into from
Jul 16, 2024
Merged

graduate PersistentVolumeLastPhaseTransitionTime to GA in v1.31 #46463

merged 1 commit into from
Jul 16, 2024

Conversation

RomanBednar
Copy link
Contributor

@RomanBednar RomanBednar commented May 20, 2024 •
edited
Loading

graduate PersistentVolumeLastPhaseTransitionTime to GA in v1.31

KEP: kubernetes/enhancements#3762
k/k: kubernetes/kubernetes#124969

@k8s-ci-robot k8s-ci-robot added this to the 1.31 milestone May 20, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 20, 2024
@netlify Netlify
Copy link

netlify bot commented May 20, 2024 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit c07a108
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6662c66199f3f10008d9af95

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label May 20, 2024
@k8s-ci-robot k8s-ci-robot requested review from tengqm and thockin May 20, 2024 11:53
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label May 20, 2024
@RomanBednar RomanBednar mentioned this pull request May 20, 2024
Closed
12 tasks
@netlify Netlify
Copy link

netlify bot commented May 20, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit c07a108
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6662c661a48924000849679a
😎 Deploy Preview https://deploy-preview-46463--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RomanBednar RomanBednar force-pushed the pv-last-phase-transition-time-ga branch from edb669e to 62e20ca Compare May 21, 2024 10:04
@dipesh-rawat
Copy link
Member

The upstream changes as part of kubernetes/kubernetes#124969 hasn’t been merged yet.
@RomanBednar It would be helpful to also include a link to the upstream PR with the code changes in the description.

/hold
Holding this PR for now.
(Okay to unhold once the upstream changes are merged)

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 23, 2024
Arhell
Arhell reviewed May 27, 2024
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/easycla

@network-charles
Copy link
Contributor

Hi @RomanBednar, I noticed you haven't signed the CLA yet. Kindly sign the CLA to make your current and future PRs valid.

@RomanBednar
Copy link
Contributor Author

/easycla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 29, 2024
@network-charles
Copy link
Contributor

/easycla

Thanks!

carlory
carlory reviewed Jun 5, 2024
View reviewed changes
...e/command-line-tools-reference/feature-gates/persistent-volume-last-phase-transition-time.md Outdated
- stage: stable
defaultValue: true
fromVersion: "1.31"
toVersion: "1.33"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filling toVersion is better when the feature gate is removed from k/k. @RomanBednar

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, removed.

@RomanBednar RomanBednar force-pushed the pv-last-phase-transition-time-ga branch from 62e20ca to eb223c1 Compare June 5, 2024 07:30
@RomanBednar RomanBednar force-pushed the pv-last-phase-transition-time-ga branch from eb223c1 to c07a108 Compare June 7, 2024 08:35
@MaryamTavakkoli
Copy link
Contributor

Hello @RomanBednar👋 Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday July 16th 2024 18:00 PST. Thank you!

@RomanBednar
Copy link
Contributor Author

RomanBednar commented Jul 16, 2024 •
edited
Loading

kubernetes/kubernetes#124969 is now merged

/assign @tengqm
/cc @dipesh-rawat
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 16, 2024
@tengqm
Copy link
Contributor

tengqm commented Jul 16, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2024
@carlory
Copy link
Member

carlory commented Jul 16, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8d212c0bfdb90258603508a8581280fa2c427af0

@k8s-ci-robot k8s-ci-robot merged commit 6786d24 into kubernetes:dev-1.31 Jul 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlory carlory carlory left review comments

@Arhell Arhell Arhell left review comments

@tengqm tengqm tengqm left review comments

@thockin thockin Awaiting requested review from thockin

@dipesh-rawat dipesh-rawat Awaiting requested review from dipesh-rawat

Assignees

@tengqm tengqm

@carlory carlory

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.31
Development

Successfully merging this pull request may close these issues.
8 participants
@RomanBednar @dipesh-rawat @network-charles @MaryamTavakkoli @tengqm @k8s-ci-robot @carlory @Arhell