-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add other error message for metrics-server in default kubeadm config #45779
Conversation
…ration This is the error message currently printed by the default-manifest metrics-server for a default kubeadm cluster installation for every node.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @adamency! |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @adamency, Sign EasyCLA first. |
Here are links -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/easycla
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, you'd have to sign the CLA as the bot instructed.
#45779 (comment)
is there some link or reference that this is a message from metrics server?
@utkarsh-singh1 @Arhell @neolit123 Yes I know, I had already looked at the checks list and went to the link to integrate EasyCLA to my account, however it is asking much more than other solutions where I have been used to only be required to sign-off the commits, so I will need time to think about it when I'm less busy and do the required steps. @neolit123 I will also then provide with a screenshot where we can see that I'm actually printing the logs for a metrics-server container if that is sufficient ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, no need. looks like it's confirmed by this ticket
kubernetes-sigs/metrics-server#196
change LGTM, thanks
/lgtm
/sig cluster-lifecycle
LGTM label has been added. Git tree hash: d3328beaae42af7171b6053eb32e0286cc051690
|
@@ -469,6 +469,7 @@ on the side of the metrics-server: | |||
``` | |||
x509: certificate signed by unknown authority | |||
x509: certificate is valid for IP-foo not IP-bar | |||
x509: cannot validate certificate for IP-foo because it doesn't contain any IP SANs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
every error message should be documented.
thanks
/lgtm |
Hi @adamency, you haven’t signed the Contributor License Agreement (CLA) yet. Kindly sign the agreement to proceed with this PR. |
/close |
@tengqm: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is the error message currently printed by the default-manifest metrics-server for a default kubeadm cluster installation for every node.
I believe this PR will make troubleshooting the metrics-server on a basic kubeadm install easier because this error message currently brings very few results online for kubernetes as it is not documented anywhere, even in the project repository.