Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add other error message for metrics-server in default kubeadm config #45779

Closed
wants to merge 1 commit into from

Conversation

adamency
Copy link

@adamency adamency commented Apr 5, 2024

This is the error message currently printed by the default-manifest metrics-server for a default kubeadm cluster installation for every node.

I believe this PR will make troubleshooting the metrics-server on a basic kubeadm install easier because this error message currently brings very few results online for kubernetes as it is not documented anywhere, even in the project repository.

…ration

This is the error message currently printed by the default-manifest metrics-server for a default kubeadm cluster installation for every node.
Copy link

CLA Not Signed

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign divya-mohan0209 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Apr 5, 2024
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 5, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @adamency!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 5, 2024
Copy link

netlify bot commented Apr 5, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 17d580b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/660f55b0422285000831ecfa
😎 Deploy Preview https://deploy-preview-45779--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@utkarsh-singh1
Copy link
Contributor

Hi @adamency, Sign EasyCLA first.

@utkarsh-singh1
Copy link
Contributor

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/easycla

Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, you'd have to sign the CLA as the bot instructed.
#45779 (comment)

is there some link or reference that this is a message from metrics server?

@adamency
Copy link
Author

adamency commented Apr 5, 2024

@utkarsh-singh1 @Arhell @neolit123 Yes I know, I had already looked at the checks list and went to the link to integrate EasyCLA to my account, however it is asking much more than other solutions where I have been used to only be required to sign-off the commits, so I will need time to think about it when I'm less busy and do the required steps.

@neolit123 I will also then provide with a screenshot where we can see that I'm actually printing the logs for a metrics-server container if that is sufficient ?

Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, no need. looks like it's confirmed by this ticket
kubernetes-sigs/metrics-server#196

change LGTM, thanks
/lgtm
/sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Apr 5, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d3328beaae42af7171b6053eb32e0286cc051690

@@ -469,6 +469,7 @@ on the side of the metrics-server:
```
x509: certificate signed by unknown authority
x509: certificate is valid for IP-foo not IP-bar
x509: cannot validate certificate for IP-foo because it doesn't contain any IP SANs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

every error message should be documented.
thanks

@kundan2707
Copy link
Contributor

/lgtm

@network-charles
Copy link
Contributor

Hi @adamency, you haven’t signed the Contributor License Agreement (CLA) yet. Kindly sign the agreement to proceed with this PR.

@tengqm
Copy link
Contributor

tengqm commented May 4, 2024

/close
Please feel free to reopen this (or open a new PR) when the CLA is signed.

@k8s-ci-robot
Copy link
Contributor

@tengqm: Closed this PR.

In response to this:

/close
Please feel free to reopen this (or open a new PR) when the CLA is signed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants