Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promote feature PodSchedulingReadiness to stable #45234

Merged
merged 1 commit into from
Mar 15, 2024
Merged

promote feature PodSchedulingReadiness to stable #45234

merged 1 commit into from
Mar 15, 2024

Conversation

Huang-Wei
Copy link
Member

Ref kubernetes/enhancements#3521.

(A placeholder for now)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 21, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 21, 2024 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 42af37b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/65f365c8f9e3b40008d335b9

@Huang-Wei Huang-Wei mentioned this pull request Feb 21, 2024
Closed
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Feb 21, 2024
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Feb 21, 2024
@Shubham82
Copy link
Contributor

The corresponding changes for the PodSchedulingReadiness flag still don't occur in the kubernetes/kubernetes repo. Once It is done we can update this. Until then we can put it on hold.

Please remove the hold label once it is done.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2024
@ahg-g
Copy link
Member

ahg-g commented Feb 21, 2024 •
edited
Loading

@Huang-Wei can we please also update this https://kubernetes.io/docs/concepts/scheduling-eviction/pod-scheduling-readiness/#mutable-pod-scheduling-directives in the same PR? they both use the same flag.

Specifically the part "FEATURE STATE: Kubernetes v1.27 [beta]" should probably be completely removed

@Huang-Wei Huang-Wei force-pushed the 1.30/PodSchedulingReadiness-stable branch from 502196d to 84c09a1 Compare March 2, 2024 17:25
@Huang-Wei
Copy link
Member Author

@Huang-Wei can we please also update this kubernetes.io/docs/concepts/scheduling-eviction/pod-scheduling-readiness/#mutable-pod-scheduling-directives in the same PR? they both use the same flag.

Specifically the part "FEATURE STATE: Kubernetes v1.27 [beta]" should probably be completely removed

Sure, updated. Thanks.

@Vyom-Yadav
Copy link
Member

Vyom-Yadav commented Mar 5, 2024 •
edited
Loading

Hey @Huang-Wei 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday March 12th 2024 18:00 PST. Thank you!

I think this is already ready, so just a friendly reminder :)

@Huang-Wei
Copy link
Member Author

I think this is already ready, so just a friendly reminder :)

Yup, I think it's ready for review. @ahg-g could you take a second look?

@Huang-Wei Huang-Wei force-pushed the 1.30/PodSchedulingReadiness-stable branch from 84c09a1 to a923199 Compare March 6, 2024 02:40
@Shubham82
Copy link
Contributor

Hi @Huang-Wei
you also have to update the PodSchedulingReadiness feature gate stage in the Feature Gates document.

@Shubham82
Copy link
Contributor

I'm removing the /hold label as corresponding changes for the PodSchedulingReadiness flag done in the upstream. Here is the following PR:kubernetes/kubernetes#123575

@Shubham82
Copy link
Contributor

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2024
@Huang-Wei
Copy link
Member Author

Hi @Huang-Wei
you also have to update the PodSchedulingReadiness feature gate stage in the Feature Gates document.

IIUC that feature gate doc (index.md) is auto-generated by compiling all the individual feature gate's page. And the feature gate's markdown file has been updated. Please let me know if I miss anything.

@Shubham82
Copy link
Contributor

Hi @Huang-Wei
you also have to update the PodSchedulingReadiness feature gate stage in the Feature Gates document.

IIUC that feature gate doc (index.md) is auto-generated by compiling all the individual feature gate's page. And the feature gate's markdown file has been updated. Please let me know if I miss anything.

Hi @Huang-Wei, you are right, This change happened in the last release(k8s v1.29) by PR #41793, and I missed it.
Thanks for the information.

@Shubham82
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 99eba6ba3d441462ac7b4f60553991f7972ba5cd

sftim
sftim reviewed Mar 12, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/hold

@Huang-Wei there is a nit, but if you prefer to just unhold, you are welcome to do that.

content/en/docs/concepts/scheduling-eviction/pod-scheduling-readiness.md Outdated
@@ -91,8 +91,6 @@ scheduling. You can use `scheduler_pending_pods{queue="gated"}` to check the met

## Mutable Pod Scheduling Directives
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For GA, we like to follow the style guide, so I recommend

Suggested change
## Mutable Pod Scheduling Directives
## Mutable Pod scheduling directives

but, it won't block a merge.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Updated. PTAL.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 12, 2024
@Huang-Wei Huang-Wei force-pushed the 1.30/PodSchedulingReadiness-stable branch from a923199 to 42af37b Compare March 14, 2024 21:01
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2024
@k8s-ci-robot k8s-ci-robot requested a review from Shubham82 March 14, 2024 21:02
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 14, 2024
@tengqm
Copy link
Contributor

tengqm commented Mar 15, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Shubham82
Copy link
Contributor

/unhold
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 15, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 34870114a6511744af9dca8cf0b1b8b055c9cae0

@k8s-ci-robot k8s-ci-robot merged commit 7e1ed16 into kubernetes:dev-1.30 Mar 15, 2024
6 checks passed
@drewhagen
Copy link
Member

/milestone 1.30

@k8s-ci-robot k8s-ci-robot added this to the 1.30 milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g ahg-g left review comments

@sftim sftim sftim left review comments

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@reylejano reylejano Awaiting requested review from reylejano

@Shubham82 Shubham82 Awaiting requested review from Shubham82

Assignees

@Shubham82 Shubham82

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.30
Development

Successfully merging this pull request may close these issues.
8 participants
@Huang-Wei @Shubham82 @ahg-g @Vyom-Yadav @k8s-ci-robot @tengqm @drewhagen @sftim