Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KEP-2400] Update swap with beta2 deprecations #45128

Merged
merged 2 commits into from
Mar 12, 2024
Merged

[KEP-2400] Update swap with beta2 deprecations #45128

merged 2 commits into from
Mar 12, 2024

Conversation

kannon92
Copy link
Contributor

@kannon92 kannon92 commented Feb 13, 2024 •
edited
Loading

In our code, we removed UnlimitedSwap and added a default setting of NoSwap.

Waiting on kubernetes/kubernetes#122745

@netlify Netlify
Copy link

netlify bot commented Feb 13, 2024 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit dabb663
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/65eeff3b92c1cf0008db53b3

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 13, 2024
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Feb 13, 2024
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Feb 13, 2024
@dipesh-rawat
Copy link
Member

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Feb 13, 2024
sftim
sftim reviewed Feb 13, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still true:

To enable swap on a node, the NodeSwap feature gate must be enabled on
the kubelet, and the --fail-swap-on command line flag or failSwapOn
configuration setting
must be set to false.

@kannon92
Copy link
Contributor Author

Is this still true:

To enable swap on a node, the NodeSwap feature gate must be enabled on
the kubelet, and the --fail-swap-on command line flag or failSwapOn
configuration setting
must be set to false.

I'll update that.

@kannon92
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 13, 2024
@kannon92
Copy link
Contributor Author

hold for kubernetes/kubernetes#122745

@kannon92 kannon92 mentioned this pull request Feb 13, 2024
Open
60 tasks
@reylejano
Copy link
Member

/milestone 1.30

@k8s-ci-robot k8s-ci-robot added this to the 1.30 milestone Feb 16, 2024
@Princesso
Copy link
Contributor

Hello @kannon92 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday March 12th 2024 18:00 PST. Thank you!

@kannon92
Copy link
Contributor Author

/hold cancel

This PR is good to go for 1.30 since k/k PR merged.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2024
@iholder101
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f08ae545eba14eed19fdafbd408323ce3808744d

@sftim
Copy link
Contributor

sftim commented Mar 12, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5eeb67c into kubernetes:dev-1.30 Mar 12, 2024
6 checks passed
@drewhagen
Copy link
Member

/milestone 1.30

@k8s-ci-robot k8s-ci-robot added this to the 1.30 milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iholder101 iholder101 iholder101 left review comments

@sftim sftim sftim left review comments

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@iholder101 iholder101

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
1.30
Development

Successfully merging this pull request may close these issues.
8 participants
@kannon92 @dipesh-rawat @reylejano @Princesso @iholder101 @k8s-ci-robot @sftim @drewhagen