Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix highlighting for added lines #44954

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Fix highlighting for added lines #44954

merged 1 commit into from
Feb 1, 2024

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Jan 30, 2024 •
edited
Loading

This is a small fixup for #44915

It helps people correctly see what lines have been added.

Existing page section
Preview

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels Jan 30, 2024
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jan 30, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 30, 2024

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 5a859a7
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65b936b1a6e93500088f95ec
😎 Deploy Preview https://deploy-preview-44954--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stmcginnis
Copy link
Contributor

/lgtm

Looks good:
image

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8332745e6b990a9f7bff49ba65000a1f0cd00045

kundan2707
kundan2707 reviewed Feb 1, 2024
View reviewed changes
Copy link
Contributor

@kundan2707 kundan2707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@reylejano
Copy link
Member

The proposed changes looks good
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2024
@k8s-ci-robot k8s-ci-robot merged commit b50ee8e into kubernetes:main Feb 1, 2024
6 checks passed
@sftim sftim deleted the 20240130_fix_highlighting branch February 1, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kundan2707 kundan2707 kundan2707 left review comments

@dipesh-rawat dipesh-rawat Awaiting requested review from dipesh-rawat

@vishh vishh Awaiting requested review from vishh

Assignees

@stmcginnis stmcginnis

@kundan2707 kundan2707

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sftim @stmcginnis @k8s-ci-robot @reylejano @kundan2707