Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs around sidecar containers #44800

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Update docs around sidecar containers #44800

merged 2 commits into from
Feb 1, 2024

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Jan 18, 2024

Update the documentation around sidecar containers.

This wording fits having at least one minor release after v1.29, so I've targeted the branch dev-1.30.

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jan 18, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 18, 2024 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit d9723d7
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/65af88013174ee0008651141

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Jan 18, 2024
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 18, 2024
@bart0sh
Copy link
Contributor

bart0sh commented Jan 21, 2024

/cc @SergeyKanzhelev

@sftim @Ritikaa96
Fix spelling
d9723d7 
Co-authored-by: Ritika <[email protected]>
@Ritikaa96
Copy link
Contributor

thanks @sftim
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 17db74123515c76750f6b927ebc2ac86fa861202

@T-Lakshmi T-Lakshmi mentioned this pull request Jan 30, 2024
Closed
@reylejano
Copy link
Member

Thank you, the proposed changes improve the docs
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2024
@k8s-ci-robot k8s-ci-robot merged commit 74aea81 into kubernetes:dev-1.30 Feb 1, 2024
6 checks passed
@sftim sftim deleted the 20240118_improve_sidecar_container_docs branch February 1, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ritikaa96 Ritikaa96 Ritikaa96 requested changes

@bradtopol bradtopol Awaiting requested review from bradtopol

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

Assignees

@Ritikaa96 Ritikaa96

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sftim @bart0sh @Ritikaa96 @k8s-ci-robot @reylejano