Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise explanation for DefaultHostNetworkHostPortsInPodTemplates #44626

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Revise explanation for DefaultHostNetworkHostPortsInPodTemplates #44626

merged 1 commit into from
Feb 2, 2024

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Jan 3, 2024 •
edited
Loading

Reword the explanation for the DefaultHostNetworkHostPortsInPodTemplates feature gate.

preview

/sig network
/language en

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. language/en Issues or PRs related to English language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 3, 2024
@k8s-ci-robot k8s-ci-robot requested a review from onlydole January 3, 2024 23:42
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jan 3, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 3, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 3b2873b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65bd0006ac9f57000876a33c
😎 Deploy Preview https://deploy-preview-44626--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Shubham82
Copy link
Contributor

Thanks @sftim
The preview looks good to me:
https://deploy-preview-44626--kubernetes-io-main-staging.netlify.app/docs/reference/command-line-tools-reference/feature-gates/

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 414f0cc4c6f9563a52e2183f39d28e035f471522

divya-mohan0209
divya-mohan0209 reviewed Jan 22, 2024
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and conveys the same message in a better way. Thank you for this, @sftim !
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divya-mohan0209

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2024
@divya-mohan0209
Copy link
Contributor

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2024
@divya-mohan0209
Copy link
Contributor

@kubernetes/sig-network-pr-reviews : PTAL.

@shaneutt
Copy link
Member

shaneutt commented Feb 1, 2024

/cc @danwinship @aojea @shaneutt @MikeZappa87 @thockin

@MikeZappa87
Copy link

This feature is deprecated, is it being removed? @thockin

@sftim
Copy link
Contributor Author

sftim commented Feb 1, 2024

(we have a policy that we document all current features, even if deprecated)

@aojea
Copy link
Member

aojea commented Feb 2, 2024

This feature is deprecated, is it being removed? @thockin

it was added as deprecated , it is a technique of using feature flags to protect of unexpected problems so we can roll back safely

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2024
@sftim sftim force-pushed the 20240103_default_host_network_ports_in_pod_templates branch from 6b39687 to 3b2873b Compare February 2, 2024 14:45
@sftim
Copy link
Contributor Author

sftim commented Feb 2, 2024

I judge from #44626 (review) that this is OK to unhold.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2024
@aojea
Copy link
Member

aojea commented Feb 2, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 57f8733312cac4dc0b54b57fd66ec1494fa48550

@k8s-ci-robot k8s-ci-robot merged commit d8b3cd4 into kubernetes:main Feb 2, 2024
6 checks passed
@sftim sftim deleted the 20240103_default_host_network_ports_in_pod_templates branch October 12, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divya-mohan0209 divya-mohan0209 divya-mohan0209 left review comments

@aojea aojea aojea left review comments

@onlydole onlydole Awaiting requested review from onlydole

@windsonsea windsonsea Awaiting requested review from windsonsea

@danwinship danwinship Awaiting requested review from danwinship

@MikeZappa87 MikeZappa87 Awaiting requested review from MikeZappa87

@shaneutt shaneutt Awaiting requested review from shaneutt

@thockin thockin Awaiting requested review from thockin

@Shubham82 Shubham82 Awaiting requested review from Shubham82

Assignees

@aojea aojea

@Shubham82 Shubham82

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sftim @Shubham82 @k8s-ci-robot @divya-mohan0209 @shaneutt @MikeZappa87 @aojea