Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added description for KonnectivityService #44598

Closed
wants to merge 1 commit into from
Closed

added description for KonnectivityService #44598

wants to merge 1 commit into from

Conversation

haripriya9647
Copy link
Contributor

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign katcosgrove for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 1, 2024
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jan 1, 2024
@k8s-ci-robot k8s-ci-robot requested a review from onlydole January 1, 2024 14:52
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 1, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 1, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit aeb9dc2
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6594229caf564600073ff94f
😎 Deploy Preview https://deploy-preview-44598--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sftim
sftim reviewed Jan 1, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Please see the inline feedback

content/en/docs/tasks/extend-kubernetes/setup-konnectivity.md Outdated Show resolved Hide resolved
content/en/docs/tasks/extend-kubernetes/setup-konnectivity.md Outdated Show resolved Hide resolved
@haripriya9647
Copy link
Contributor Author

haripriya9647 commented Jan 2, 2024 •
edited
Loading

@sftim I have added commit

sftim
sftim reviewed Jan 2, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this? See the pages I've linked to for more detail.

I don't think we should frame Konnectivity as “vital” to a cluster - it isn't.

content/en/docs/tasks/extend-kubernetes/setup-konnectivity.md Outdated Show resolved Hide resolved
content/en/docs/tasks/extend-kubernetes/setup-konnectivity.md Outdated Show resolved Hide resolved
@haripriya9647
added description for KonnectivityService
3e2f782 
Update setup-konnectivity.md

Update setup-konnectivity.md

new commit
@haripriya9647
Copy link
Contributor Author

done

@sftim
Copy link
Contributor

sftim commented Jan 2, 2024

LGTM for docs

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jan 2, 2024
@divya-mohan0209
Copy link
Contributor

@kubernetes/sig-api-machinery-pr-reviews : PTAL

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 3, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 3, 2024
@divya-mohan0209
Copy link
Contributor

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 4, 2024
@divya-mohan0209
Copy link
Contributor

Left a message on the API Machinery Slack channel

@divya-mohan0209
Copy link
Contributor

Pinging SIG API Machinery Leads and left a message on Slack

@kubernetes/sig-api-machinery-leads PTAL

deads2k
deads2k reviewed Aug 12, 2024
View reviewed changes
content/en/docs/tasks/extend-kubernetes/setup-konnectivity.md
Comment on lines +9 to +11
Kubernetes can use an optional proxy mechanism, _Konnectivity_, that helps you connect
your control plane's {{< glossary_tooltip text="API servers" term_id="kube-apiserver" >}}
to your nodes, to {{< glossary_tooltip term_id="etcd" >}}, or to aggregated API servers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't the konnectivity service be used for all three egress types: controlplane (authn, authz, admission, conversion webhooks), etcd, and cluster (self-hosted aggregated apiservers)?

deads2k
deads2k reviewed Aug 12, 2024
View reviewed changes
content/en/docs/tasks/extend-kubernetes/setup-konnectivity.md
your control plane's {{< glossary_tooltip text="API servers" term_id="kube-apiserver" >}}
to your nodes, to {{< glossary_tooltip term_id="etcd" >}}, or to aggregated API servers.

The proxy operates at a stream layer, independent of packets and network routes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what this sentence means. The apiserver has to be able to reach the konnectivity server and then the konnectivity server can tunnel as appropriate.

@johnnyboystar22 johnnyboystar22 mentioned this pull request Aug 12, 2024
Closed
@tengqm
Copy link
Contributor

tengqm commented Oct 27, 2024

/close
Closing for inactivity for over 9 months since last change.

@k8s-ci-robot
Copy link
Contributor

@tengqm: Closed this PR.

In response to this:

/close
Closing for inactivity for over 9 months since last change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@deads2k deads2k deads2k left review comments

@dipesh-rawat dipesh-rawat Awaiting requested review from dipesh-rawat

@onlydole onlydole Awaiting requested review from onlydole

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@haripriya9647 @k8s-ci-robot @sftim @divya-mohan0209 @k8s-triage-robot @tengqm @deads2k