Feature gate SchedulerQueueingHints is disabled by default #44316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
sig/docs
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
ahg-g
reviewed
Dec 13, 2023
content/en/docs/concepts/scheduling-eviction/scheduling-framework.md
Outdated
Show resolved
Hide resolved
sftim
previously requested changes
Dec 13, 2023
k8s-ci-robot
added
the
do-not-merge/hold
sanposhiho
force-pushed
the
qhint-fix
branch
from
723e996 to
2520994
Compare
k8s-ci-robot
added
area/release-eng
|
@sftim Fixed. |
pacoxu
reviewed
Dec 13, 2023
| @@ -184,7 +184,8 @@ For a reference to old feature gates that are removed, please refer to | |||
| | `SELinuxMountReadWriteOncePod` | `false` | Alpha | 1.25 | 1.26 | | |||
| | `SELinuxMountReadWriteOncePod` | `false` | Beta | 1.27 | 1.27 | | |||
| | `SELinuxMountReadWriteOncePod` | `true` | Beta | 1.28 | | | |||
| | `SchedulerQueueingHints` | `true` | Beta | 1.28 | | | |||
| | `SchedulerQueueingHints` | `true` | Beta | 1.28.0 | 1.28.5 | | |||
| | `SchedulerQueueingHints` | `false` | Beta | 1.29 | | | |||
There was a problem hiding this comment.
IIUC, SchedulerQueueingHints will be disabled by default in 1.28.6+ as well later. (after kubernetes/kubernetes#122291 is merged.)
There was a problem hiding this comment.
Let's make not that change until it's true.
sftim
reviewed
Dec 13, 2023
content/en/docs/reference/command-line-tools-reference/feature-gates.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
You might want to revise the description text for SchedulerQueueingHints (later in the file).
| @@ -184,7 +184,8 @@ For a reference to old feature gates that are removed, please refer to | |||
| | `SELinuxMountReadWriteOncePod` | `false` | Alpha | 1.25 | 1.26 | | |||
| | `SELinuxMountReadWriteOncePod` | `false` | Beta | 1.27 | 1.27 | | |||
| | `SELinuxMountReadWriteOncePod` | `true` | Beta | 1.28 | | | |||
| | `SchedulerQueueingHints` | `true` | Beta | 1.28 | | | |||
| | `SchedulerQueueingHints` | `true` | Beta | 1.28.0 | 1.28.5 | | |||
| | `SchedulerQueueingHints` | `false` | Beta | 1.29 | | | |||
There was a problem hiding this comment.
Let's make not that change until it's true.
…-gates.md Co-authored-by: Tim Bannister <[email protected]>
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
sftim
reviewed
Dec 13, 2023
content/en/docs/concepts/scheduling-eviction/scheduling-framework.md
Outdated
Show resolved
Hide resolved
Avoid mentioning change we expect for a future (patch) release
k8s-ci-robot
added
size/S
|
/hold cancel Base branch is now correct. |
k8s-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divya-mohan0209 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 9b29f7a5dda3f49b676bdba2619d900c7ef56dcc
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature gate SchedulerQueueingHints is disabled by default.
kubernetes/kubernetes#122289
This PR reflects it on the doc.