Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that UnauthenticatedHTTP2DOSMitigation default in 1.29 is set to true #44177

Conversation

troy0820
Copy link
Member

@troy0820 troy0820 commented Dec 1, 2023

In 1.28.3 this feature gate was introduced but was set to false. In 1.29 this feature gate is set to true by default.

This resolves #44122 for dev-1.29

@k8s-ci-robot k8s-ci-robot added this to the 1.29 milestone Dec 1, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 1, 2023
Copy link

netlify bot commented Dec 1, 2023

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 9795352
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6569fdf1f775d7000849e64b

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 1, 2023
@sftim
Copy link
Contributor

sftim commented Dec 1, 2023

/retitle Document that UnauthenticatedHTTP2DOSMitigation default in 1.29 is set to true

@k8s-ci-robot k8s-ci-robot changed the title UnauthenticatedHTTP2DOSMitigation default in 1.29 is set to true Document that UnauthenticatedHTTP2DOSMitigation default in 1.29 is set to true Dec 1, 2023
Comment on lines 634 to 636
- `LoadBalancerIPMode`: Allows setting `ipMode` for Services where `type` is set to `LoadBalancer`.
See [Specifying IPMode of load balancer status](/docs/concepts/services-networking/service/#load-balancer-ip-mode)
- `LoadBalancerIPMode`: Allows setting `ipMode` for Services where `type` is set to `LoadBalancer`.
See [Specifying IPMode of load balancer status](/docs/concepts/services-networking/service/#load-balancer-ip-mode)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please omit this (unrelated) change

Comment on lines 748 to 753
that are relevant to the unscheduled pod, based on previous scheduling attempts.
that are relevant to the unscheduled pod, based on previous scheduling attempts.
- `SeccompDefault`: Enables the use of `RuntimeDefault` as the default seccomp profile
for all workloads.
The seccomp profile is specified in the `securityContext` of a Pod and/or a Container.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please omit this (unrelated) change

@troy0820 troy0820 force-pushed the troy0820/update-feature-gate-dev-1.29 branch from bdd780a to 4f470f2 Compare December 1, 2023 15:33
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 1, 2023
@troy0820 troy0820 force-pushed the troy0820/update-feature-gate-dev-1.29 branch 2 times, most recently from f6482e5 to 2e1f12a Compare December 1, 2023 15:35
@troy0820 troy0820 force-pushed the troy0820/update-feature-gate-dev-1.29 branch from 2e1f12a to 9795352 Compare December 1, 2023 15:38
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is OK to merge, because I know that the main branch has a description for UnauthenticatedHTTP2DOSMitigation, and that the description would therefore be present after the release - which is when it counts.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dd1c70c1d0c9b0009eabe918e165adc41fbd32dd

@katcosgrove
Copy link
Contributor

/assign @bradtopol

Copy link
Contributor

@kundan2707 kundan2707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit f6b5c5f into kubernetes:dev-1.29 Dec 3, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants