-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document that UnauthenticatedHTTP2DOSMitigation default in 1.29 is set to true #44177
Document that UnauthenticatedHTTP2DOSMitigation default in 1.29 is set to true #44177
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
/retitle Document that UnauthenticatedHTTP2DOSMitigation default in 1.29 is set to true |
- `LoadBalancerIPMode`: Allows setting `ipMode` for Services where `type` is set to `LoadBalancer`. | ||
See [Specifying IPMode of load balancer status](/docs/concepts/services-networking/service/#load-balancer-ip-mode) | ||
- `LoadBalancerIPMode`: Allows setting `ipMode` for Services where `type` is set to `LoadBalancer`. | ||
See [Specifying IPMode of load balancer status](/docs/concepts/services-networking/service/#load-balancer-ip-mode) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please omit this (unrelated) change
that are relevant to the unscheduled pod, based on previous scheduling attempts. | ||
that are relevant to the unscheduled pod, based on previous scheduling attempts. | ||
- `SeccompDefault`: Enables the use of `RuntimeDefault` as the default seccomp profile | ||
for all workloads. | ||
The seccomp profile is specified in the `securityContext` of a Pod and/or a Container. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please omit this (unrelated) change
bdd780a
to
4f470f2
Compare
f6482e5
to
2e1f12a
Compare
Signed-off-by: Troy Connor <[email protected]>
2e1f12a
to
9795352
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is OK to merge, because I know that the main branch has a description for UnauthenticatedHTTP2DOSMitigation
, and that the description would therefore be present after the release - which is when it counts.
/lgtm
LGTM label has been added. Git tree hash: dd1c70c1d0c9b0009eabe918e165adc41fbd32dd
|
/assign @bradtopol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In 1.28.3 this feature gate was introduced but was set to false. In 1.29 this feature gate is set to true by default.
This resolves #44122 for dev-1.29