Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve visibility for tutorial diagrams through color change #43719

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Improve visibility for tutorial diagrams through color change #43719

merged 1 commit into from
Dec 9, 2023

Conversation

PranitRout07
Copy link
Contributor

Solves issue #43711

SCREENSHOT OF DIAGRAM BEFORE UPDATE

Screenshot 2023-10-27 152210

SCREENSHOT OF DIAGRAM AFTER UPDATE
Screenshot 2023-10-28 161709

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 28, 2023
@k8s-ci-robot k8s-ci-robot requested a review from kbhawkey October 28, 2023 12:07
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 28, 2023
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 28, 2023
@netlify
Copy link

netlify bot commented Oct 28, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 5c49e61
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/653cf98eb7a5ee0008d36ffa
😎 Deploy Preview https://deploy-preview-43719--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@windsonsea
Copy link
Member

The diagram contrast looks better.

/lgtm

Our diagram style has no this kind of color (yellow or orange) spec yet.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 86f0a2dde124d61c4264dfec35f4dca651a912a8

@PranitRout07
Copy link
Contributor Author

Hi @windsonsea color used is almost similar to yellow and orange , so that's why i mentioned changing yellow color to orange color. :)

aj11anuj
aj11anuj approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@aj11anuj aj11anuj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to add a colour to style guide? As this one looks good to me for diagrams. 👍

@PranitRout07
Copy link
Contributor Author

Hey @aj11anuj i have used this color #F29202 .

@sftim
Copy link
Contributor

sftim commented Dec 9, 2023

/retitle Improve visibility for tutorial diagram through color change

I'm changing the title because what we pick ends up in the commit history.

@k8s-ci-robot k8s-ci-robot changed the title docs: Resolves visibility issue by changing yellow to orange color Improve visibility for tutorial diagram through color change Dec 9, 2023
@sftim
Copy link
Contributor

sftim commented Dec 9, 2023

Is there any way to add a colour to style guide? As this one looks good to me for diagrams. 👍

The page to update: https://kubernetes.io/docs/contribute/style/diagram-guide/

sftim
sftim approved these changes Dec 9, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aj11anuj, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2023
@sftim sftim changed the title Improve visibility for tutorial diagram through color change Improve visibility for tutorial diagrams through color change Dec 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit c064885 into kubernetes:main Dec 9, 2023
4 checks passed
@Gauravpadam Gauravpadam mentioned this pull request Jan 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aj11anuj aj11anuj aj11anuj approved these changes

@sftim sftim sftim approved these changes

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@reylejano reylejano Awaiting requested review from reylejano

Assignees

@windsonsea windsonsea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PranitRout07 @windsonsea @k8s-ci-robot @sftim @aj11anuj