Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[id] fix: update deprecated command in code example #43630

Merged
merged 1 commit into from
Oct 23, 2023
Merged

[id] fix: update deprecated command in code example #43630

merged 1 commit into from
Oct 23, 2023

Conversation

Arhell
Copy link
Member

@Arhell Arhell commented Oct 21, 2023

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 21, 2023
@k8s-ci-robot k8s-ci-robot added language/id Issues or PRs related to Indonesian language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 21, 2023
@netlify
Copy link

netlify bot commented Oct 21, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 30b42be
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65344574ca8e860008922dd2
😎 Deploy Preview https://deploy-preview-43630--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dipesh-rawat
dipesh-rawat reviewed Oct 21, 2023
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update to the command looks inline with 'en' PR.
LGTM

Preview Page

@girikuncoro
Copy link
Contributor

thanks for the fix @Arhell 🎉

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c9782eb80785ec6cfedcfad198880c2b14145e59

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girikuncoro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9aa26d8 into kubernetes:main Oct 23, 2023
3 checks passed
@Arhell Arhell deleted the id-fix branch October 23, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@danninov danninov Awaiting requested review from danninov

@girikuncoro girikuncoro Awaiting requested review from girikuncoro

Assignees

@girikuncoro girikuncoro

@ariscahyadi ariscahyadi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Arhell @girikuncoro @k8s-ci-robot @dipesh-rawat @ariscahyadi