Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[id] update about sidecar containers #43604

Merged
merged 1 commit into from
Oct 20, 2023
Merged

[id] update about sidecar containers #43604

merged 1 commit into from
Oct 20, 2023

Conversation

qassandrach
Copy link
Contributor

add section for sidecar containers & example

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 20, 2023
@k8s-ci-robot k8s-ci-robot added language/id Issues or PRs related to Indonesian language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 20, 2023
@qassandrach
Copy link
Contributor Author

/cc @girikuncoro

@netlify
Copy link

netlify bot commented Oct 20, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit d7dcc4f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6532477efb23560008a6ced0
😎 Deploy Preview https://deploy-preview-43604--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@girikuncoro
Copy link
Contributor

girikuncoro commented Oct 20, 2023 •
edited
Loading

nice one, thanks a lot for the contributions @qassandrach 🎉

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girikuncoro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f33e87d83fa94b1b75650c359bfcc648ee435a61

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit e3c2662 into kubernetes:main Oct 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danninov danninov Awaiting requested review from danninov

@habibrosyad habibrosyad Awaiting requested review from habibrosyad

@girikuncoro girikuncoro Awaiting requested review from girikuncoro

Assignees

@girikuncoro girikuncoro

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qassandrach @girikuncoro @k8s-ci-robot