Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graduate PersistentVolumeLastPhaseTransitionTime to beta in v1.29 #43532

Merged
merged 1 commit into from
Nov 3, 2023
Merged

graduate PersistentVolumeLastPhaseTransitionTime to beta in v1.29 #43532

merged 1 commit into from
Nov 3, 2023

Conversation

RomanBednar
Copy link
Contributor

The PersistentVolumeLastPhaseTransitionTime feature is moving to beta in 1.29: kubernetes/kubernetes#120627

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 17, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 17, 2023
@netlify
Copy link

netlify bot commented Oct 17, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 3df9a0a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/652e98724b0c7300083ba56d
😎 Deploy Preview https://deploy-preview-43532--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RomanBednar RomanBednar changed the base branch from main to dev-1.29 October 17, 2023 14:24
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 17, 2023
@RomanBednar RomanBednar force-pushed the pv-last-phase-transition-time-beta branch from 3df9a0a to 52cb1d1 Compare October 17, 2023 14:26
@netlify
Copy link

netlify bot commented Oct 17, 2023 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit d485edf
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/652f9d3910a61a00084d0173

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 17, 2023
@RomanBednar RomanBednar mentioned this pull request Oct 17, 2023
Closed
12 tasks
@sftim
Copy link
Contributor

sftim commented Oct 17, 2023

/sig storage

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Oct 17, 2023
@tengqm
Copy link
Contributor

tengqm commented Oct 18, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 60b12a3b60fb6d65c70783c7d6a08fd17419c84c

@tengqm
Copy link
Contributor

tengqm commented Oct 18, 2023

/hold
Hold till the upstream PR is merged.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 18, 2023
@RomanBednar RomanBednar force-pushed the pv-last-phase-transition-time-beta branch from 52cb1d1 to d485edf Compare October 18, 2023 08:54
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2023
@k8s-ci-robot k8s-ci-robot requested a review from tengqm October 18, 2023 08:54
@RomanBednar
Copy link
Contributor Author

@tengqm ptal again, lgtm label was removed since I updated the PR

@tengqm
Copy link
Contributor

tengqm commented Oct 18, 2023

@RomanBednar It's fine. We have several pairs of eyes watching these PRs going into dev-1.29.
The upstream PR is not yet merged anyway.

@Princesso
Copy link
Contributor

Hello @RomanBednar 👋, please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 14th November 2023. Thank you!

@RomanBednar
Copy link
Contributor Author

/unhold
Upstream PR is now merged: kubernetes/kubernetes#120627

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 30, 2023
@jsafrane
Copy link
Member

jsafrane commented Nov 2, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5bdda7007b89e2a2100ae3be7cbd4723fd701f70

@tengqm
Copy link
Contributor

tengqm commented Nov 3, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5e8aebc into kubernetes:dev-1.29 Nov 3, 2023
3 checks passed
@k8s-ci-robot k8s-ci-robot added this to the 1.29 milestone Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@mehabhalodiya mehabhalodiya Awaiting requested review from mehabhalodiya

@saad-ali saad-ali Awaiting requested review from saad-ali

@tengqm tengqm Awaiting requested review from tengqm

Assignees

@jsafrane jsafrane

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.29
Development

Successfully merging this pull request may close these issues.
6 participants
@RomanBednar @sftim @tengqm @k8s-ci-robot @Princesso @jsafrane