-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update enforce-standards-admission-controller.md #43528
Conversation
It seems comment was set to a wrong field. There is no need to change apiserver.config.k8s.io/VERSION, we need to modify only pod-security.admission.config.k8s.io/VERSION
|
Welcome @Alexhha! |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
/easycla |
@Alexhha Please sign EasyCLA |
Thanks for the PR, but the comment is correct. The version of the config file depends on the version of the API server and earlier versions of the server required a prerelease version of the config file |
/close |
@liggitt: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@liggitt
and it failed with the following message
So the correct one is
|
/reopen Apologies, you are correct. I misread the description as applying to the version of the pod security labels |
@liggitt: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
LGTM label has been added. Git tree hash: 4d4906a5b5f9ba8938b92411f070ab583133a9b0
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It seems comment was set to a wrong field. There is no need to change apiserver.config.k8s.io/VERSION, we need to modify only pod-security.admission.config.k8s.io/VERSION