Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update enforce-standards-admission-controller.md #43528

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

Alexhha
Copy link
Contributor

@Alexhha Alexhha commented Oct 17, 2023

It seems comment was set to a wrong field. There is no need to change apiserver.config.k8s.io/VERSION, we need to modify only pod-security.admission.config.k8s.io/VERSION

It seems comment was set to a wrong field. There is no need to change apiserver.config.k8s.io/VERSION, we need to modify only pod-security.admission.config.k8s.io/VERSION
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 17, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Alexhha / name: Alex Domoradov (2d8edf7)

@k8s-ci-robot
Copy link
Contributor

Welcome @Alexhha!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 17, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 17, 2023
@netlify
Copy link

netlify bot commented Oct 17, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 2d8edf7
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/652e698803ccd900084ca58b
😎 Deploy Preview https://deploy-preview-43528--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 17, 2023
@kundan2707
Copy link
Contributor

/easycla

@kundan2707
Copy link
Contributor

@Alexhha Please sign EasyCLA

@liggitt
Copy link
Member

liggitt commented Oct 17, 2023

Thanks for the PR, but the comment is correct. The version of the config file depends on the version of the API server and earlier versions of the server required a prerelease version of the config file

@liggitt
Copy link
Member

liggitt commented Oct 17, 2023

/close

@k8s-ci-robot
Copy link
Contributor

@liggitt: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Alexhha
Copy link
Contributor Author

Alexhha commented Oct 17, 2023

@liggitt
I tried the following config on kubernetes 1.23

apiVersion: apiserver.config.k8s.io/v1beta1
kind: AdmissionConfiguration
plugins:
- name: PodSecurity
  configuration:
    apiVersion: pod-security.admission.config.k8s.io/v1beta1
    kind: PodSecurityConfiguration
...

and it failed with the following message

{"log":"E1017 10:38:01.552286       1 run.go:120] \"command failed\" err=\"failed to initialize admission: failed to read plugin config: no kind \\\"AdmissionConfiguration\\\" is registered for version \\\"apiserver.config.k8s.io/v1beta1\\\" in scheme \\\"k8s.io/apiserver/pkg/server/options/admission.go:44\\\"\"\n","stream":"stderr","time":"2023-10-17T10:38:01.552400438Z"}

So the correct one is

apiVersion: apiserver.config.k8s.io/v1 <== MUST BE v1 and not v1beta1
kind: AdmissionConfiguration
plugins:
- name: PodSecurity
  configuration:
    apiVersion: pod-security.admission.config.k8s.io/v1beta1
    kind: PodSecurityConfiguration

@liggitt
Copy link
Member

liggitt commented Oct 17, 2023

/reopen

Apologies, you are correct. I misread the description as applying to the version of the pod security labels

@k8s-ci-robot k8s-ci-robot reopened this Oct 17, 2023
@k8s-ci-robot
Copy link
Contributor

@liggitt: Reopened this PR.

In response to this:

/reopen

Apologies, you are correct. I misread the description as applying to the version of the pod security labels

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liggitt
Copy link
Member

liggitt commented Oct 17, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4d4906a5b5f9ba8938b92411f070ab583133a9b0

@tengqm
Copy link
Contributor

tengqm commented Oct 18, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit 14fe28f into kubernetes:main Oct 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants