Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce of the deprecated FG: MergeCLIArgumentsWithConfig #43515

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Introduce of the deprecated FG: MergeCLIArgumentsWithConfig #43515

merged 1 commit into from
Oct 17, 2023

Conversation

chendave
Copy link
Member

The feature gate is added by this change: kubernetes/kubernetes#119946

Also see the link for the comments: kubernetes/kubernetes#119946 (comment)

@k8s-ci-robot k8s-ci-robot added this to the 1.29 milestone Oct 17, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 17, 2023
@netlify
Copy link

netlify bot commented Oct 17, 2023 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 1c73d4a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/652df5ae17f269000808a957

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 17, 2023
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 17, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 17, 2023
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 17, 2023
@chendave chendave mentioned this pull request Oct 17, 2023
Closed
@chendave
Copy link
Member Author

/cc @windsonsea @neolit123 @pacoxu

@tengqm
Copy link
Contributor

tengqm commented Oct 17, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2023
pacoxu
pacoxu reviewed Oct 17, 2023
View reviewed changes
Copy link
Member

@pacoxu pacoxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 524530b0f656990bbc0b540c924c4720b8589f12

@k8s-ci-robot k8s-ci-robot merged commit bff157a into kubernetes:dev-1.29 Oct 17, 2023
3 checks passed
@chendave chendave deleted the dev-1.29 branch October 17, 2023 05:27
@chendave chendave mentioned this pull request Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@pacoxu pacoxu pacoxu left review comments

@dipesh-rawat dipesh-rawat Awaiting requested review from dipesh-rawat

@reylejano reylejano Awaiting requested review from reylejano

@neolit123 neolit123 Awaiting requested review from neolit123

@windsonsea windsonsea Awaiting requested review from windsonsea

Assignees

@pacoxu pacoxu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.29
Development

Successfully merging this pull request may close these issues.
4 participants
@chendave @tengqm @k8s-ci-robot @pacoxu