Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh] fix: update deprecated command in code example #43493

Merged
merged 1 commit into from
Oct 15, 2023
Merged

[zh] fix: update deprecated command in code example #43493

merged 1 commit into from
Oct 15, 2023

Conversation

Arhell
Copy link
Member

@Arhell Arhell commented Oct 14, 2023

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 14, 2023
@k8s-ci-robot k8s-ci-robot added the language/zh Issues or PRs related to Chinese language label Oct 14, 2023
@k8s-ci-robot k8s-ci-robot requested a review from ydFu October 14, 2023 22:29
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 14, 2023
@netlify
Copy link

netlify bot commented Oct 14, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 5ff3eb0
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/652b1661deb9380008931308
😎 Deploy Preview https://deploy-preview-43493--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dipesh-rawat
dipesh-rawat reviewed Oct 14, 2023
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposed change looks inline with 'en' PR.
LGTM

Preview Page

@tengqm
Copy link
Contributor

tengqm commented Oct 15, 2023

Thanks.
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 16a56254031cad7480c60fcec9acb91a27c97d67

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit fdd3a4a into kubernetes:main Oct 15, 2023
3 checks passed
@Arhell Arhell deleted the zh-fix branch October 15, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@mengjiao-liu mengjiao-liu Awaiting requested review from mengjiao-liu

@ydFu ydFu Awaiting requested review from ydFu

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Arhell @tengqm @k8s-ci-robot @dipesh-rawat