Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Set up kubectl on Linux docs and bug fix #43481

Closed

Conversation

Community-Programmer
Copy link
Contributor

@Community-Programmer Community-Programmer commented Oct 13, 2023

Subject: New PR for 'Install and Set Up kubectl on Linux' Documentation Fixes
Solves the issue : #43366

Dear Reviewers and Maintainers,

I closed PR #43393 and opend this one because I've made further improvements and fixes to the 'Install and Set Up kubectl on Linux' documentation. I believe that these changes will significantly enhance the quality and accuracy of the documentation.

Fix 1:
fixed the typo error in the zn-ch docs for Installation and Setting Up kubectl on Linux

273606918-30a2ebc9-66c0-430f-8165-9d1a7aa72f33

Fix 2:
Translated the new tab about SUSE-based distributions (zn-ch)

image

Fix 3:

Fixed the content merging of two tabs in Install using native package management

nec2

Fix 4:
Removed the unwanted html tag in the bash (en)

nec

I apologize for any confusion caused by the previous PR. I am committed to ensuring that the documentation is as helpful and reliable as possible and am grateful for your assistance in reviewing and merging these changes.

Your feedback and suggestions are highly appreciated

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 13, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 13, 2023
@netlify
Copy link

netlify bot commented Oct 13, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit b9bb81d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/652edc31321c7a00089d9858
😎 Deploy Preview https://deploy-preview-43481--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.


1. Install kubectl using `zypper`:

2. Install kubectl using `zypper`:
```bash
sudo zypper install -y kubectl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Community-Programmer, close it with ```.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thank you for the guidance will copy the same

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have PR #43444, which was raised earlier to address the layout problem in this page. The changes made here somewhat duplicate with the ones in that PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for bringing this to my attention. I've reviewed PR #43444, which was raised earlier to address layout problems on this page, and I understand that the changes in my current PR may somewhat duplicate those in PR #43444.

To ensure the most efficient and coordinated approach, could you please advise whether it would be best to remove the duplicated changes from my current PR? If there are any unique aspects in my changes that could still be beneficial, I'd be happy to discuss how to incorporate them effectively.

@dipesh-rawat
Copy link
Member

@Community-Programmer Thanks for your contribution. This PR seems to affect files in different languages (English and Chinese). However, the documentation process varies for each localization, and we usually prefer not to merge PRs that affect multiple languages at once. It's advisable to focus on a single language in a single PR. I hope this suggestion is helpful.

@dipesh-rawat
Copy link
Member

Applying hold until PR targets only single language.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2023
@Community-Programmer
Copy link
Contributor Author

Community-Programmer commented Oct 14, 2023

@Community-Programmer Thanks for your contribution. This PR seems to affect files in different languages (English and Chinese). However, the documentation process varies for each localization, and we usually prefer not to merge PRs that affect multiple languages at once. It's advisable to focus on a single language in a single PR. I hope this suggestion is helpful.

Thank you for your feedback and guidance. I appreciate the suggestion to focus on a single language in a single PR to streamline the documentation process.

I'll take this advice to heart and will be splitting this PR into multiple PRs, each dedicated to a specific language. To facilitate this, I'll create a new branch and proceed accordingly. I'll keep you updated once the language-specific PRs are ready for review.

@Community-Programmer
Copy link
Contributor Author

@dipesh-rawat @utkarsh-singh1 Should I create a new PR for the same

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 15, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language language/zh Issues or PRs related to Chinese language needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants