Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify SchedulerQueueingHints #43427

Merged
merged 5 commits into from
Oct 12, 2023
Merged

Conversation

sanposhiho
Copy link
Member

@sanposhiho sanposhiho commented Oct 11, 2023

This feature gate is kind of unique one, added as Beta and enabled by default from the first step.

https://github.com/kubernetes/kubernetes/blob/master/pkg/features/kube_features.go#L777

/kind documentation
/kind bug

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 11, 2023
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 11, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Oct 11, 2023
@sanposhiho
Copy link
Member Author

sanposhiho commented Oct 11, 2023

/triage accepted

@kubernetes/sig-docs-en-owners It's important since the current doc is completely wrong. PTAL. 🙏

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Oct 11, 2023
@netlify
Copy link

netlify bot commented Oct 11, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit f20a9ce
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6526af973b55610008c7334b
😎 Deploy Preview https://deploy-preview-43427--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Co-authored-by: Qiming Teng <[email protected]>
@tengqm
Copy link
Contributor

tengqm commented Oct 11, 2023

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 11, 2023
@tengqm
Copy link
Contributor

tengqm commented Oct 11, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9cfbc01d742bbe3667c7e7f71e42df0cb8618eb3

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2023
@k8s-ci-robot k8s-ci-robot requested a review from tengqm October 11, 2023 14:22
@alculquicondor
Copy link
Member

/approve

@alculquicondor
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2579bccaaca2fc18813984d7baf64a561aa7dda2

@tengqm
Copy link
Contributor

tengqm commented Oct 12, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit caed9a1 into kubernetes:main Oct 12, 2023
3 checks passed
Community-Programmer pushed a commit to Community-Programmer/website that referenced this pull request Oct 13, 2023
* Modify `SchedulerQueueingHints`

* fix: QueueingHint is enabled by default

* Add more context in the description

* format the description

Co-authored-by: Qiming Teng <[email protected]>

* Update the description of QueueingHint feature

Co-authored-by: Aldo Culquicondor <[email protected]>

---------

Co-authored-by: Qiming Teng <[email protected]>
Co-authored-by: Aldo Culquicondor <[email protected]>
aojea pushed a commit to aojea/website that referenced this pull request Oct 18, 2023
* Modify `SchedulerQueueingHints`

* fix: QueueingHint is enabled by default

* Add more context in the description

* format the description

Co-authored-by: Qiming Teng <[email protected]>

* Update the description of QueueingHint feature

Co-authored-by: Aldo Culquicondor <[email protected]>

---------

Co-authored-by: Qiming Teng <[email protected]>
Co-authored-by: Aldo Culquicondor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants