Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[es] Fix sha256 url missing '/release/' to download kubectl #43423

Merged
merged 1 commit into from
Oct 11, 2023
Merged

[es] Fix sha256 url missing '/release/' to download kubectl #43423

merged 1 commit into from
Oct 11, 2023

Conversation

Arhell
Copy link
Member

@Arhell Arhell commented Oct 10, 2023

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 10, 2023
@k8s-ci-robot k8s-ci-robot requested review from 92nqb and raelga October 10, 2023 21:22
@k8s-ci-robot k8s-ci-robot added language/es Issues or PRs related to Spanish language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 10, 2023
@ramrodo
Copy link
Member

ramrodo commented Oct 10, 2023

/retest

@netlify
Copy link

netlify bot commented Oct 10, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit b22fa3c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6525d53641a0f400081c57a3
😎 Deploy Preview https://deploy-preview-43423--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dipesh-rawat
dipesh-rawat reviewed Oct 10, 2023
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposed URL changes looks in sync with 'en' PR.
LGTM

Preview Page

@ramrodo
Copy link
Member

ramrodo commented Oct 11, 2023

Thanks!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 965f590e3568b21c6fbb0a7a4e2c4aa83fb6759a

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ramrodo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7bbd4d6 into kubernetes:main Oct 11, 2023
3 checks passed
@Arhell Arhell deleted the es-256 branch October 11, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@92nqb 92nqb Awaiting requested review from 92nqb

@raelga raelga Awaiting requested review from raelga

Assignees

@ramrodo ramrodo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/es Issues or PRs related to Spanish language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Arhell @ramrodo @k8s-ci-robot @dipesh-rawat