Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature blog for ReadWriteOncePod GA graduation #43418

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Feature blog for ReadWriteOncePod GA graduation #43418

merged 1 commit into from
Dec 13, 2023

Conversation

chrishenzie
Copy link
Member

@chrishenzie chrishenzie commented Oct 10, 2023 •
edited
Loading

Used the beta graduation blog post as a template: #39817

Feature: kubernetes/kubernetes#121077
Enhancement: kubernetes/enhancements#2485

/sig storage
/sig scheduling
CC @msau42

@k8s-ci-robot k8s-ci-robot added this to the 1.29 milestone Oct 10, 2023
@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. labels Oct 10, 2023
@netlify
Copy link

netlify bot commented Oct 10, 2023 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit df721bb
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6553e26909b79200086a7827

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/blog Issues or PRs related to the Kubernetes Blog subproject labels Oct 10, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 10, 2023
@chrishenzie chrishenzie mentioned this pull request Oct 10, 2023
Closed
12 tasks
aj11anuj
aj11anuj suggested changes Oct 10, 2023
View reviewed changes
Copy link
Member

@aj11anuj aj11anuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions from my side

content/en/blog/_posts/2023-10-10-read-write-once-pod-access-mode-ga.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-10-10-read-write-once-pod-access-mode-ga.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-10-10-read-write-once-pod-access-mode-ga.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-10-10-read-write-once-pod-access-mode-ga.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-10-10-read-write-once-pod-access-mode-ga.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-10-10-read-write-once-pod-access-mode-ga.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-10-10-read-write-once-pod-access-mode-ga.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-10-10-read-write-once-pod-access-mode-ga.md Outdated Show resolved Hide resolved
@chrishenzie chrishenzie force-pushed the readwriteoncepod-ga-blog branch 2 times, most recently from de9e12e to 7eeacae Compare November 13, 2023 23:31
@sftim
Copy link
Contributor

sftim commented Nov 14, 2023

/hold

for 3 reasons:

  • this PR should target the main branch; we'll merge it just after v1.29 has released
  • the publication date isn't yet set (release comms team does this)
  • v1.29 isn't yet released

ℹ️ please leave this PR held until all three conditions have been met

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2023
@chrishenzie chrishenzie force-pushed the readwriteoncepod-ga-blog branch from 7eeacae to df721bb Compare November 14, 2023 21:11
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject language/de Issues or PRs related to German language language/es Issues or PRs related to Spanish language labels Nov 14, 2023
@chrishenzie chrishenzie changed the base branch from dev-1.29 to main November 14, 2023 21:11
@k8s-ci-robot k8s-ci-robot added language/fr Issues or PRs related to French language language/id Issues or PRs related to Indonesian language language/it Issues or PRs related to Italian language language/ru Issues or PRs related to Russian language language/uk Issues or PRs related to Ukrainian language language/vi Issues or PRs related to Vietnamese language language/zh Issues or PRs related to Chinese language sig/release Categorizes an issue or PR as relevant to SIG Release. labels Nov 14, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 02344e833f229031dbe8c3a914533602c5e98f21

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2023
@chrishenzie chrishenzie force-pushed the readwriteoncepod-ga-blog branch from 257b133 to 1ca22dc Compare November 27, 2023 16:59
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2023
@k8s-ci-robot k8s-ci-robot requested a review from sftim November 27, 2023 16:59
@chrishenzie chrishenzie mentioned this pull request Nov 27, 2023
Merged
@sftim
Copy link
Contributor

sftim commented Nov 27, 2023

/hold

Do not merge until Kubernetes v1.29 is released.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 799d3ebb3db4da097233d74877edd00989174127

kcmartin
kcmartin suggested changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@kcmartin kcmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Kristin from the 1.29 Comms Team requesting a couple of punctuation changes.

content/en/blog/_posts/2023-12-12-read-write-once-pod-access-mode-ga.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-12-12-read-write-once-pod-access-mode-ga.md Outdated Show resolved Hide resolved
@chrishenzie chrishenzie force-pushed the readwriteoncepod-ga-blog branch from 1ca22dc to a92f9a5 Compare November 29, 2023 17:11
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2023
@sftim sftim mentioned this pull request Nov 29, 2023
Merged
@krol3
Copy link
Contributor

krol3 commented Dec 1, 2023 •
edited
Loading

Hi @chrishenzie , Release 1.29 has been postponed, Please assign new date on Dec 18th. cc: @@kubernetes/sig-docs-blog-owners @Priyankasaggu11929 @sftim @James-Quigley @kcmartin

@sftim
Copy link
Contributor

sftim commented Dec 1, 2023

/lgtm cancel
/approve cancel

Requires new date

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2023
@chrishenzie chrishenzie force-pushed the readwriteoncepod-ga-blog branch from a92f9a5 to 1439264 Compare December 1, 2023 19:00
@chrishenzie
Copy link
Member Author

Updated to 12/18

@sftim
Copy link
Contributor

sftim commented Dec 4, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 35f9c1dd3cf7c1413a915c32126d3416a22d2da1

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2023
@Gauravpadam
Copy link
Member

Thanks

With v1.29 released, This looks good to go

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8d6a481 into kubernetes:main Dec 13, 2023
6 checks passed
@chrishenzie chrishenzie deleted the readwriteoncepod-ga-blog branch December 13, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aj11anuj aj11anuj aj11anuj requested changes

@kcmartin kcmartin kcmartin requested changes

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@sftim sftim Awaiting requested review from sftim

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Docs Blog Project Board
Status: Published
SIG Scheduling
Archived in project
Milestone
1.29
Development

Successfully merging this pull request may close these issues.
8 participants
@chrishenzie @sftim @krol3 @tengqm @k8s-ci-robot @Gauravpadam @kcmartin @aj11anuj