Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graduate ReadWriteOncePod to GA #43417

Merged
merged 1 commit into from
Nov 25, 2023
Merged

Graduate ReadWriteOncePod to GA #43417

merged 1 commit into from
Nov 25, 2023

Conversation

chrishenzie
Copy link
Member

@chrishenzie chrishenzie commented Oct 10, 2023 •
edited
Loading

Update references to ReadWriteOncePod feature gate to indicate it's GA / stable.

Feature: kubernetes/kubernetes#121077
Enhancement: kubernetes/enhancements#2485

/sig storage
/sig scheduling
/cc @msau42

@k8s-ci-robot k8s-ci-robot requested a review from msau42 October 10, 2023 14:57
@k8s-ci-robot k8s-ci-robot added this to the 1.29 milestone Oct 10, 2023
@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. labels Oct 10, 2023
@netlify
Copy link

netlify bot commented Oct 10, 2023 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit c07ce39
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/655cea5a2c970900087c556f

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 10, 2023
@chrishenzie chrishenzie mentioned this pull request Oct 10, 2023
Closed
12 tasks
sftim
sftim reviewed Oct 10, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

content/en/docs/concepts/storage/persistent-volumes.md Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2023
Arhell
Arhell reviewed Oct 16, 2023
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-push commit to restart netlify

@Princesso
Copy link
Contributor

Hello @chrishenzie 👋, Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 14th November 2023. Thank you!

@Princesso
Copy link
Contributor

Hello @chrishenzie 👋, gebtle reminder to take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 14th November 2023. Thank you!

@Princesso
Copy link
Contributor

Hello @chrishenzie 👋, gentle reminder to take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before tomorrow, Tuesday 14th November 2023. Thank you!

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 13, 2023
@chrishenzie
Copy link
Member Author

/assign sftim
/assign jsafrane
/assign xing-yang

@chrishenzie
Copy link
Member Author

@Princesso Acknowledged, thank you! Ready for review now.

@xing-yang
Copy link
Contributor

I see that it has no merge conflicts now, but for some reason, the "needs-rebase" label is not removed automatically.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 14, 2023
sftim
sftim reviewed Nov 14, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

I recommend updating

to explain why the page uses ReadWriteOnce (ie, it's just an example), and to recommend ReadWriteOncePod for production use.

content/en/docs/tasks/administer-cluster/change-pv-access-mode-readwriteoncepod.md Outdated Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/change-pv-access-mode-readwriteoncepod.md Show resolved Hide resolved
content/en/docs/concepts/storage/persistent-volumes.md Outdated Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/change-pv-access-mode-readwriteoncepod.md Outdated Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/change-pv-access-mode-readwriteoncepod.md Outdated Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/change-pv-access-mode-readwriteoncepod.md Outdated Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/change-pv-access-mode-readwriteoncepod.md Outdated Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/change-pv-access-mode-readwriteoncepod.md Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/change-pv-access-mode-readwriteoncepod.md Outdated Show resolved Hide resolved
sftim
sftim reviewed Nov 15, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Here's a new round of feedback.

content/en/docs/concepts/workloads/controllers/statefulset.md Outdated Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/change-pv-access-mode-readwriteoncepod.md Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/change-pv-access-mode-readwriteoncepod.md Outdated Show resolved Hide resolved
content/en/docs/tasks/configure-pod-container/configure-persistent-volume-storage.md Outdated Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/change-pv-access-mode-readwriteoncepod.md Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/change-pv-access-mode-readwriteoncepod.md Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/change-pv-access-mode-readwriteoncepod.md Outdated Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/change-pv-access-mode-readwriteoncepod.md Outdated Show resolved Hide resolved
@chrishenzie chrishenzie force-pushed the readwriteoncepod-ga branch 2 times, most recently from 1a4395a to 8c30d92 Compare November 15, 2023 21:42
@sftim
Copy link
Contributor

sftim commented Nov 15, 2023

This looks ready for tech review.
@kubernetes/sig-storage-pr-reviews please take a look.

@xing-yang
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b39502f3f804c544d32f9af85b44370e2f8a3127

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2023
@chrishenzie
Copy link
Member Author

@sftim I changed all references to K8s versions (1.29) to prefix with "v" (e.g. v1.29) for both the blog and this doc, but not for the blog title because I saw that pattern used less frequently. What's your preference? Thanks!

@sftim
Copy link
Contributor

sftim commented Nov 17, 2023

@sftim I changed all references to K8s versions (1.29) to prefix with "v" (e.g. v1.29) for both the blog and this doc, but not for the blog title because I saw that pattern used less frequently. What's your preference? Thanks!

I have no preference. In docs, I pick whichever I think will help the reader understand best.

@sunnylovestiramisu sunnylovestiramisu mentioned this pull request Nov 20, 2023
Merged
@chrishenzie
Graduate ReadWriteOncePod to GA
c07ce39 
Included is a task for migrating existing PersistentVolumes to use
ReadWriteOncePod, taken from the alpha blog post.
@Princesso
Copy link
Contributor

Hello @chrishenzie 👋, gentle reminder to get your PR merged before the deadline, Tuesday 28th November 2023. Thank you!

@Princesso
Copy link
Contributor

/assign @sftim
/assign @tengqm
/assign sig-storage

@k8s-ci-robot
Copy link
Contributor

@Princesso: GitHub didn't allow me to assign the following users: sig-storage.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @sftim
/assign @tengqm
/assign sig-storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tengqm
Copy link
Contributor

tengqm commented Nov 25, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2023
@sftim
Copy link
Contributor

sftim commented Nov 25, 2023

Tech LGTM: #43417 (comment)
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: df67a967b9ad3d43a52a2ec207ff86e80e673dfd

@k8s-ci-robot k8s-ci-robot merged commit da5638c into kubernetes:dev-1.29 Nov 25, 2023
6 checks passed
@chrishenzie chrishenzie deleted the readwriteoncepod-ga branch November 27, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell left review comments

@msau42 msau42 Awaiting requested review from msau42

@jsafrane jsafrane Awaiting requested review from jsafrane

@sftim sftim Awaiting requested review from sftim

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@xing-yang xing-yang

@jsafrane jsafrane

@tengqm tengqm

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Scheduling
Archived in project
Milestone
1.29
Development

Successfully merging this pull request may close these issues.
8 participants
@chrishenzie @Princesso @xing-yang @sftim @k8s-ci-robot @tengqm @Arhell @jsafrane