Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rapture reference for build admins #43408

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Remove rapture reference for build admins #43408

merged 1 commit into from
Oct 10, 2023

Conversation

saschagrunert
Copy link
Member

Package builds are now integrated into krel obs, means we do not have to reference rapture any more. It also got removed in kubernetes/release#3313.

/cc @kubernetes/release-managers

@k8s-ci-robot
Copy link
Contributor

@saschagrunert: GitHub didn't allow me to request PR reviews from the following users: kubernetes/release-managers.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Package builds are now integrated into krel obs, means we do not have to reference rapture any more. It also got removed in kubernetes/release#3313.

/cc @kubernetes/release-managers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 10, 2023
@saschagrunert saschagrunert mentioned this pull request Oct 10, 2023
Closed
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Oct 10, 2023
@xmudrii
Copy link
Member

xmudrii commented Oct 10, 2023

@saschagrunert Should we also update or remove the Build Admins section in this file? We don't have the concept of Build Admins with OBS.

@saschagrunert
Remove rapture reference for build admins
f833be4 
Package builds are now integrated into `krel obs`, means we do not have
to reference rapture any more. It also got removed in
kubernetes/release#3313.

Signed-off-by: Sascha Grunert <[email protected]>
@saschagrunert
Copy link
Member Author

@xmudrii yep, done 👍

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 10, 2023
xmudrii
xmudrii approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 16bb348e7593373781d2264ca0f34b5e2103eb27

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit e5b31b8 into kubernetes:main Oct 10, 2023
@saschagrunert saschagrunert mentioned this pull request Oct 10, 2023
Merged
@saschagrunert saschagrunert deleted the rapture branch October 10, 2023 13:13
@netlify
Copy link

netlify bot commented Oct 10, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit f833be4
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/652548f838a4870008b8f015
😎 Deploy Preview https://deploy-preview-43408--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pacoxu added a commit to pacoxu/security that referenced this pull request Jan 8, 2024
@pacoxu
update release roles link
daf0289 
- remove build admins due to kubernetes/website#43408
@pacoxu pacoxu mentioned this pull request Jan 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saschagrunert @k8s-ci-robot @xmudrii