Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs update for JobPodsReady in GA #43387

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Docs update for JobPodsReady in GA #43387

merged 1 commit into from
Nov 7, 2023

Conversation

mimowo
Copy link
Contributor

@mimowo mimowo commented Oct 9, 2023

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2023
@k8s-ci-robot k8s-ci-robot added this to the 1.29 milestone Oct 9, 2023
@netlify
Copy link

netlify bot commented Oct 9, 2023 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 6886cad
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6548a8b19944340008b8adc9

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 9, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 9, 2023
@sftim
Copy link
Contributor

sftim commented Oct 9, 2023

/sig apps

@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Oct 9, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 18, 2023
@alculquicondor alculquicondor mentioned this pull request Oct 19, 2023
Closed
14 tasks
@katcosgrove
Copy link
Contributor

Hi, @mimowo! v1.29 Docs Lead here. Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 14th November 2023. Thank you!

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2023
@mimowo mimowo changed the title WIP: Docs update for JobPodsReady in GA [placeholder] Docs update for JobPodsReady in GA Nov 3, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2023
@mimowo
Copy link
Contributor Author

mimowo commented Nov 3, 2023

/assign @alculquicondor @sftim
Minimal changes for now, I could not see any existing section on the feature. Maybe we should add one?

@alculquicondor
Copy link
Member

No need. We decided that the API reference should be enough, for such a minimal feature.

alculquicondor
alculquicondor reviewed Nov 3, 2023
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c3e4a41ca3b99da7eb852307f13c1485888e182f

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2023
@alculquicondor
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2b1e5bf4dbf75fa1428621bab8b94184a2c942a2

@tengqm
Copy link
Contributor

tengqm commented Nov 7, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit aa48ad5 into kubernetes:dev-1.29 Nov 7, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@dipesh-rawat dipesh-rawat Awaiting requested review from dipesh-rawat

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@sftim sftim Awaiting requested review from sftim

Assignees

@alculquicondor alculquicondor

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Apps
Archived in project
Milestone
1.29
Development

Successfully merging this pull request may close these issues.
6 participants
@mimowo @sftim @katcosgrove @alculquicondor @k8s-ci-robot @tengqm